concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2020-03-04T21:54:10+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1511Fix recursion error events models2020-03-04T21:54:10+01:00Sébastiaan VersteegFix recursion error events modelsCloses #1015 #1018
#### Previous behaviour
Steps to reproduce:
1. Save a published event after changing it to unpublished
2. Remove a published event
#### New behaviour
Steps to validate that it works:
1. Save a published...Closes #1015 #1018
#### Previous behaviour
Steps to reproduce:
1. Save a published event after changing it to unpublished
2. Remove a published event
#### New behaviour
Steps to validate that it works:
1. Save a published event after changing it to unpublished
2. Remove a published eventJelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1510Update dependency sphinx to v2.4.32020-03-04T21:55:37+01:00Thalia TechnicieUpdate dependency sphinx to v2.4.3This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | patch | `2.4.2` -> `2.4.3` |
---
### Renovate configuration
:date: **Schedule**: "ever...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | patch | `2.4.2` -> `2.4.3` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1509Almanac questionnaire2020-03-11T19:29:51+01:00Job DoesburgAlmanac questionnaireFixes #962
### Short description
This adds a page for the 2020 almanac, containing a typeform.
### Steps to use this feature
1. Open thalia.nu/members/almanac
2. Profit
**This is a temporary feature and must be disabled a...Fixes #962
### Short description
This adds a page for the 2020 almanac, containing a typeform.
### Steps to use this feature
1. Open thalia.nu/members/almanac
2. Profit
**This is a temporary feature and must be disabled again after a deadline.**31Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1508Add create_payment helper function2020-03-04T21:54:15+01:00Sébastiaan VersteegAdd create_payment helper functionCloses #1010
### Short description
Add create_payment helper function
### Steps to use this feature
1. Use it in your codeCloses #1010
### Short description
Add create_payment helper function
### Steps to use this feature
1. Use it in your codeJob DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1506Resolve "Show deregistration disclaimer text even if not registered for event"2020-02-23T16:53:09+01:00Mark BouteResolve "Show deregistration disclaimer text even if not registered for event"Closes #1008Closes #100831https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1503Resolve "Missing translations in statistics page"2020-02-19T23:46:54+01:00Mark BouteResolve "Missing translations in statistics page"Closes #981Closes #98131https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1501Disable payment button for Thalia Pay in payment widget2020-02-19T21:48:25+01:00Marie SimonDisable payment button for Thalia Pay in payment widgetCloses #980
#### Previous behaviour
Steps to reproduce:
1. One can click the process button for Thalia Pay for a membership registration
2. It crashes
#### New behaviour
Steps to validate that it works:
1.Cannot click it anymoreCloses #980
#### Previous behaviour
Steps to reproduce:
1. One can click the process button for Thalia Pay for a membership registration
2. It crashes
#### New behaviour
Steps to validate that it works:
1.Cannot click it anymore31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1500Fixed login message visible2020-02-19T21:47:58+01:00Luc KnolFixed login message visible/label ~bug
Closes #968
#### Previous behaviour
Steps to reproduce:
1. Do not log in.
2. Go to an event for which no registration is required.
3. A login button appears.
#### New behaviour
Steps to validate that it works:.../label ~bug
Closes #968
#### Previous behaviour
Steps to reproduce:
1. Do not log in.
2. Go to an event for which no registration is required.
3. A login button appears.
#### New behaviour
Steps to validate that it works:
1. Do not log in.
2. Go to an event for which no registration is required.
3. No login button appears, a message "no registration required" is displayed.
31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1498Update dependency bleach to v3.1.12020-02-19T21:50:00+01:00Thalia TechnicieUpdate dependency bleach to v3.1.1This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [bleach](https://github.com/mozilla/bleach) | dependencies | patch | `3.1.0` -> `3.1.1` |
:warning: Release Notes retrieval for this MR we...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [bleach](https://github.com/mozilla/bleach) | dependencies | patch | `3.1.0` -> `3.1.1` |
:warning: Release Notes retrieval for this MR were skipped because no github.com credentials were available.
To add credentials for github.com to your config, please see [this guide](https://docs.renovatebot.com/install-gitlab-app/#configuring-a-token-for-githubcom-hosted-release-notes).
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1497Set Postgres Password in CI2020-02-19T21:50:16+01:00Joren VranckenSet Postgres Password in CI#### Previous behaviour
CI failed, because Postgres password was not set ([upstream commit](https://github.com/docker-library/postgres/commit/f1bc8782e7e57cc403d0b32c0e24599535859f76)).
#### New behaviour
Postgres password is set.#### Previous behaviour
CI failed, because Postgres password was not set ([upstream commit](https://github.com/docker-library/postgres/commit/f1bc8782e7e57cc403d0b32c0e24599535859f76)).
#### New behaviour
Postgres password is set.31Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1495Update dependency freezegun to v0.3.152020-02-19T21:50:00+01:00Thalia TechnicieUpdate dependency freezegun to v0.3.15This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [freezegun](https://github.com/spulec/freezegun) | dependencies | patch | `0.3.14` -> `0.3.15` |
:warning: Release Notes retrieval for thi...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [freezegun](https://github.com/spulec/freezegun) | dependencies | patch | `0.3.14` -> `0.3.15` |
:warning: Release Notes retrieval for this MR were skipped because no github.com credentials were available.
To add credentials for github.com to your config, please see [this guide](https://docs.renovatebot.com/install-gitlab-app/#configuring-a-token-for-githubcom-hosted-release-notes).
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1494Added a banner for members who are banned from certain or all events.2020-02-19T21:47:45+01:00Marthijn van den NieuwenhuizenAdded a banner for members who are banned from certain or all events.Closes #987
### Short description
Added a banner for people who are not allowed to register for certain events to contact thalia's treasurer for more information.
### Steps to use this feature
1. ban yourself
2. refresh page to see ...Closes #987
### Short description
Added a banner for people who are not allowed to register for certain events to contact thalia's treasurer for more information.
### Steps to use this feature
1. ban yourself
2. refresh page to see banner at the top.31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1493Add base class for all payable objects2020-02-12T21:14:49+01:00Sébastiaan VersteegAdd base class for all payable objectsCloses #1010
### Short description
Add base class for all payable objects
### Steps to use this feature
1. Use it in your codeCloses #1010
### Short description
Add base class for all payable objects
### Steps to use this feature
1. Use it in your code31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1492Resolve "/api/v1/token-auth does not return json on login failure"2020-02-20T08:45:53+01:00Simcha van CollemResolve "/api/v1/token-auth does not return json on login failure"Closes #975
#### Previous behaviour
Steps to reproduce:
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
#### New behaviour
Steps to validate that it works:
1. Post wrong credentials to `/api/v1/token-...Closes #975
#### Previous behaviour
Steps to reproduce:
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
#### New behaviour
Steps to validate that it works:
1. Post wrong credentials to `/api/v1/token-auth`
2. `{"error": "Unauthorized"}` is returned31Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1491Add information on sentry.io to privacy policy2020-03-04T22:03:48+01:00Jelle Besselingjelle@pingiun.comAdd information on sentry.io to privacy policyThe privacy policy now includes information on the data collected and sent to sentry.ioThe privacy policy now includes information on the data collected and sent to sentry.iohttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1490Update dependency sphinx to v2.4.22020-02-19T21:49:59+01:00Thalia TechnicieUpdate dependency sphinx to v2.4.2This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | patch | `2.4.0` -> `2.4.2` |
---
### Renovate configuration
:date: **Schedule**: "ever...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | patch | `2.4.0` -> `2.4.2` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1489Update dependency sphinx to v2.4.02020-02-19T21:50:19+01:00Thalia TechnicieUpdate dependency sphinx to v2.4.0This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | minor | `2.3.1` -> `2.4.0` |
---
### Renovate configuration
:date: **Schedule**: "ever...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | minor | `2.3.1` -> `2.4.0` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1488Create dependencies Docker image2020-02-08T22:06:54+01:00Joren VranckenCreate dependencies Docker image### Description
The goal of this MR is to create a new Docker image that contains all the dependencies of Concrexit. This image would be built using a Gitlab CI Pipeline schedule.
With this change the following would happen:
- Every...### Description
The goal of this MR is to create a new Docker image that contains all the dependencies of Concrexit. This image would be built using a Gitlab CI Pipeline schedule.
With this change the following would happen:
- Every day (or on some other schedule) a new Docker image containing only the dependencies (including the development dependencies) is being build.
- The CI jobs run using the dependencies image. This removes the dependency install time from every job.
- `poetry install` is still being run on every job, to make sure dependencies specific to that branch are being installed.
- A Docker image (`concrexit:<sha>`) is being build on every branch, but significantly faster because the dependencies image is used as the base image.
- When a production Docker is being built, a new dependencies image without the development dependencies is build first.
The advantages:
- Faster builds.
- Always build using up to date dependencies ([thaliawww/python-thalia](https://github.com/thaliawww/python-thalia) is not automatically build and updated).
- Better maintainable configuration, because everything is in this repo instead of two repos on two different platforms.
Because a lot of refactoring is being done, this MR also refactors the whole config to be consistent. 31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1487Don't build Docker image using docker-compose2020-02-19T21:50:24+01:00Joren VranckenDon't build Docker image using docker-compose### Short description
Do not use `docker-compose` to build the Docker image.
This removes the need for the (very outdated) [`thalia/docker-compose` image](https://hub.docker.com/r/thalia/docker-compose) and [thaliawww/docker-dockerco...### Short description
Do not use `docker-compose` to build the Docker image.
This removes the need for the (very outdated) [`thalia/docker-compose` image](https://hub.docker.com/r/thalia/docker-compose) and [thaliawww/docker-dockercompose repository](https://github.com/thaliawww/docker-dockercompose).31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1486Login page not visible anymore when logged-in2020-02-05T21:24:02+01:00Luc KnolLogin page not visible anymore when logged-inCloses #979
#### Previous behaviour
Steps to reproduce:
1. log in
2. visit thalia.nu/user/login
#### New behaviour
Steps to validate that it works:
1. log in
2. visit thalia.nu/user/login
3. get redirected to homeCloses #979
#### Previous behaviour
Steps to reproduce:
1. log in
2. visit thalia.nu/user/login
#### New behaviour
Steps to validate that it works:
1. log in
2. visit thalia.nu/user/login
3. get redirected to home31