concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-01-01T19:29:43+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/640Fix missing avatar field in members api2018-01-01T19:29:43+01:00Sébastiaan VersteegFix missing avatar field in members apiBasically !638 but another serializer.Basically !638 but another serializer.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/613Show no albums if the user never had a membership2017-10-22T16:47:35+02:00Tom van BusselShow no albums if the user never had a membershipCloses #166
#### Previous behaviour
Steps to reproduce:
1. Create an album.
2. Create an user without memberships
3. Go the list of albums, and notice that an album is listed, even though the user currently has no membership and had n...Closes #166
#### Previous behaviour
Steps to reproduce:
1. Create an album.
2. Create an user without memberships
3. Go the list of albums, and notice that an album is listed, even though the user currently has no membership and had no membership at the time the album was created.
#### New behaviour
Steps to validate that it works:
1. Create an album.
2. Create an user without memberships
3. Go the list of albums, and notice that no albums are listed.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/611WIP: Build docs in the docker container2017-10-20T08:03:28+02:00Jelle Besselingjelle@pingiun.comWIP: Build docs in the docker containerBuilding the docs when building the Dockerfile makes it really easy to host the docs on docs.thalia.nu. (thalia/serverconfig#74)Building the docs when building the Dockerfile makes it really easy to host the docs on docs.thalia.nu. (thalia/serverconfig#74)Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/595WIP: Make the Committee Admin a lot faster2017-10-18T19:15:32+02:00Tom van BusselWIP: Make the Committee Admin a lot fasterCloses no issue
### Short description
This MR makes the `CommitteeAdmin` a lot faster, by doing the following two things:
1. Use `raw_id_fields` for the `Member` selection in the `CommitteeMembership` inline. This avoids repeati...Closes no issue
### Short description
This MR makes the `CommitteeAdmin` a lot faster, by doing the following two things:
1. Use `raw_id_fields` for the `Member` selection in the `CommitteeMembership` inline. This avoids repeating a selection box with all users multiple times. `raw_id_fields` is a bit uglier, but still usable. Once Django 2.0 is released, we can switch the `raw_id_fields` to `autocomplete_fields`.
2. Add a number of `select_related`s in the right places.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/604Use user primary key in pizza API2017-10-14T12:33:55+02:00Sébastiaan VersteegUse user primary key in pizza API#### Previous behaviour
Steps to reproduce:
1. Create multiple users and make sure the member pk is not equal to the user model pk.
2. Create a pizza event and place an order.
3. Notice that the value of 'member' is *not equal* to the u...#### Previous behaviour
Steps to reproduce:
1. Create multiple users and make sure the member pk is not equal to the user model pk.
2. Create a pizza event and place an order.
3. Notice that the value of 'member' is *not equal* to the user model pk.
#### New behaviour
Steps to validate that it works:
1. Create multiple users and make sure the member pk is not equal to the user model pk.
2. Create a pizza event and place an order.
3. Notice that the value of 'member' is _equal_ to the user model pk.1.12https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/602WIP: Activemembers: use User instead of Member as foreign keys2017-10-11T23:30:38+02:00Tom van BusselWIP: Activemembers: use User instead of Member as foreign keysCloses no issue
### Short description
`Committee`s, `CommiteeMembership`s and `Mentorship`s are now directly linked to `User` objects instead of `Member` objects.Closes no issue
### Short description
`Committee`s, `CommiteeMembership`s and `Mentorship`s are now directly linked to `User` objects instead of `Member` objects.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/599WIP: Resolve "Make documents bilingual"2017-10-11T21:07:48+02:00Thom WiggersWIP: Resolve "Make documents bilingual"Closes #519Closes #519https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/579Fix card payment export status2017-10-02T15:05:11+02:00Sébastiaan VersteegFix card payment export statusFixes #515 on release branch.Fixes #515 on release branch.Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/504WIP: Administratietrucjes: Announce direct debit notification2017-09-21T14:29:11+02:00Sébastiaan VersteegWIP: Administratietrucjes: Announce direct debit notificationChecks #103 sub 1
### Short description
Add the ability to send emails to members to announce the direct debit.
### Steps to use this feature
1. Execute `./manage.py senddirectdebitnotification`Checks #103 sub 1
### Short description
Add the ability to send emails to members to announce the direct debit.
### Steps to use this feature
1. Execute `./manage.py senddirectdebitnotification`https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/530Add event cash manager2017-09-13T21:25:19+02:00Sébastiaan VersteegAdd event cash managerConnected to #436
### Short description
Adds ability to connect a user to an event as the 'cash manager'. Only required to do so when a cash box is needed for the event.
### Steps to use this feature
1. Create an event
2. N...Connected to #436
### Short description
Adds ability to connect a user to an event as the 'cash manager'. Only required to do so when a cash box is needed for the event.
### Steps to use this feature
1. Create an event
2. Notice the fields in the creation/edit formhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/488WIP: Thaliapp beun2017-05-31T20:58:57+02:00Luuk ScholtenWIP: Thaliapp beunhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/483Add date to exam in course view2017-05-19T20:42:51+02:00Sébastiaan VersteegAdd date to exam in course viewCloses #387
### Short description
Add date to exam in course view
### Steps to use this feature
1. Go to course page
2. Look for an exam
3. Name is formatted `title (exam date)`Closes #387
### Short description
Add date to exam in course view
### Steps to use this feature
1. Go to course page
2. Look for an exam
3. Name is formatted `title (exam date)`https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/409Created a CSV export for firstname/lastname/studentnumber for selected users.2017-03-15T20:55:10+01:00Milan van StiphoutCreated a CSV export for firstname/lastname/studentnumber for selected users.Also fixed translations for the addresses CSV.
In admin panel -> Users -> Actions, you can now export a CSV with name/student number pairs.
Closes #348Also fixed translations for the addresses CSV.
In admin panel -> Users -> Actions, you can now export a CSV with name/student number pairs.
Closes #348https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/405Temporarily disable album admin form validator2017-03-15T17:48:31+01:00Tom van BusselTemporarily disable album admin form validatorDit is een tijdelijk oplossing voor #353. Het probleem lijkt te zijn dat de content_type`s die door Windows aangeleverd worden niet kloppen, waardoor de onterecht validator faalt. Deze tijdelijke fix schakelt de validator uit. Indien ee...Dit is een tijdelijk oplossing voor #353. Het probleem lijkt te zijn dat de content_type`s die door Windows aangeleverd worden niet kloppen, waardoor de onterecht validator faalt. Deze tijdelijke fix schakelt de validator uit. Indien een verkeerd bestand wordt geüpload komt er nu geen error meer in de form, maar treedt er later een exception op. Zie !406 voor een permanente oplossing.
Closes #353https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/345WIP: Release/1.42017-03-08T20:35:51+01:00Luuk ScholtenWIP: Release/1.4## :bookmark: Thalia Website v1.4.0
## Errors resolved
- [x] Prevent board memberships from ever expiring (!304)
- [x] Fix thabloids breaking `sitemap.xml` (!308)
- [x] Display correct initial join date for consecutive committee memb...## :bookmark: Thalia Website v1.4.0
## Errors resolved
- [x] Prevent board memberships from ever expiring (!304)
- [x] Fix thabloids breaking `sitemap.xml` (!308)
- [x] Display correct initial join date for consecutive committee memberships (!313)
- [x] Update and fix translations for events app (!318)
- [x] Fix current year in statistics to mean current lecture year (!330)
- [x] Fix order of events in list view (!331)
- [x] Correctly order Thabloids in descending order (!336)
- [x] Show '?' instead of '1970' for missing committee join dates (!334)
- [x] Enforce committee membership enddates in the past (consistency with info text) (!335)
- [x] Change translation of 'jaarlaag' to 'cohort' in events app (!339)
- [x] FIx comparison of board when updating a board (!340)
- [x] Update session-stored partners upon changes (!337)
- [x] Fix 'option 3' text in styleguid (!343)
## New functionality
- [x] Add '[THALIA]' to subject of newsletters (!311)
- [x] Add warning to photo administration that full-sized photos will not be stored (!297)
- [x] Make sure models are ordered in administration dropdowns (!314)
- [x] Add events sitemap to `sitemap.xml` (!319)
- [x] Add vacancies to `sitemap.xml` (!320)
- [x] Allow events to be organized by the board (!322)
- [x] Redirect board item in menu to point to current board (!324)
- [x] Update footer and add link to gitlab (!317)
- [x] TinyMCE editor field in administration automatically cleans text when pasting (!328)
- [x] Update introduction text for vacancies page (!332, !356)
- [x] Add app for creating and displaying announcements (!338)
- [x] Add support for uploading photo albums as `tar` files (!341)
- [x] Improve default ordering of pizzas and orders in overview (!344)
- [x] Improve board urls, and add check that makes sure only one board per year exists (!325)
## Technical changes
- [x] Report test coverage in README (!301, !357)
- [x] Report Django errors to Slack (in new channel) (!309)
- [x] Test the ThaliApp API (!290)
- [x] Fix warning in tests (!312)
- [x] Clarify some things about settings with additional documentation (!315)
- [x] Mark PDF ad binary in git repo (!316)
- [x] Fix uniqueness of url namespaces (!326)
- [x] Fix Django 2.0 compatibility of active member validation (!323)
- [x] Update requirements (!327)
- [x] Add pip conflict checks to testing pipeline (!333)
- [x] Remove duplicate CSS and unused images from theme (!329)
- [x] Set up `sphinx` documentation for the project (!342)
## Hotfixes
- [x] The waiting list should only include non-cancels (!360, !361, !362) (also backported into 1.3.2)https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/394Only compile docs after merges to master2017-03-01T21:28:35+01:00Luuk ScholtenOnly compile docs after merges to masterWe don't have to compile our docs every time, this greatly slows
down the build process.We don't have to compile our docs every time, this greatly slows
down the build process.Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/370Make usernames case insensitive.2017-02-22T20:09:57+01:00Jim DriessenMake usernames case insensitive.Closes #319Closes #319https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/352[Release 1.4] Make announcements work using production settings2017-02-11T21:19:42+01:00Joost Rijneveldjoost@joostrijneveld.nl[Release 1.4] Make announcements work using production settingsMake announcements work using production settings
See merge request !351Make announcements work using production settings
See merge request !351https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/303WIP: Release/1.32017-02-08T21:26:54+01:00Luuk ScholtenWIP: Release/1.3## :bookmark: Thalia Website v1.3.0
## Errors resolved
- [x] Fix context of "order" translation, making it 'bestellen' i.p.v. 'volgorde' (!291)
- [x] Fix ordering of numeric data in pizza frontend, sorting now makes sense (!287)
...## :bookmark: Thalia Website v1.3.0
## Errors resolved
- [x] Fix context of "order" translation, making it 'bestellen' i.p.v. 'volgorde' (!291)
- [x] Fix ordering of numeric data in pizza frontend, sorting now makes sense (!287)
- [x] Fix some style issues (!274)
- [x] Fix "view on site" for vacancies backend (!293)
- [x] Improve exam and summary upload form (!294)
## New functionality
- [x] Translate Thalia Logo Images (!300)
- [x] Make sure members cannot cancel or change pizza order when not allowed (!295)
- [x] Add message to the end of the newsletter regarding language change (!299)
- :truck: Add possibility to change order of newsletter items (!298)
## Technical changes
- [x] Refactor parts of CSS (!274)
- [x] Wiki API unit tested (!286)
- [x] Remove all old migration scripts, for migrating from old site to new (!296)https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/321Change Newsletter description fields to TextField and use linebreaks tag to o...2017-01-25T15:08:12+01:00Sébastiaan VersteegChange Newsletter description fields to TextField and use linebreaks tag to output correct HTMLCloses #237Closes #237