concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2020-01-25T17:45:08+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1464Setup review hosts in private subnet2020-01-25T17:45:08+01:00Joren VranckenSetup review hosts in private subnetCloses #997
### Description
This merge requests does the following:
- It uses a new version of the EC2 instance template. The new template creates instances in a private subnet. Instances do not get a public IPv4 address anymore...Closes #997
### Description
This merge requests does the following:
- It uses a new version of the EC2 instance template. The new template creates instances in a private subnet. Instances do not get a public IPv4 address anymore.
- It replaces the use of `.reviewhost` domains with `*.public.review.technicie.nl` and `*.private.review.technicie.nl` domains. `*.public.review.technicie.nl` points to `refter` (a server that acts as a NAT gateway from the public subnet to the private subnet). `*.private.review.technicie.nl` points to private IPv4 addresses within the private review subnet.
`refter` has the following `nginx` config to route the HTTP traffic:
```
server {
listen 80 default_server;
listen [::]:80 default_server;
server_name _;
return 301 https://$host$request_uri;
}
server {
listen 443 ssl http2 default_server;
listen [::]:443 ssl http2 default_server;
server_name _;
ssl on;
ssl_certificate /etc/letsencrypt/live/public.review.technicie.nl/fullchain.pem;
ssl_certificate_key /etc/letsencrypt/live/public.review.technicie.nl/privkey.pem;
return 404;
}
server {
listen 443;
listen [::]:443;
server_name "~^(?<mr_slug>[-a-z0-9]{1,63})\.public\.review\.technicie\.nl$";
ssl on;
ssl_certificate /etc/letsencrypt/live/public.review.technicie.nl/fullchain.pem;
ssl_certificate_key /etc/letsencrypt/live/public.review.technicie.nl/privkey.pem;
location / {
resolver 127.0.0.53;
proxy_pass http://$mr_slug.private.review.technicie.nl$request_uri;
}
}
```
- HTTPS does not seem to be working correctly in the current setup (for me atleast). This MR does work with HTTPS.
After this is merged. The following things should be cleaned up:
- [ ] The IAM users and policies that are not used anymore.
- [ ] The `.reviewhost` hosted zone in Route 53.
- [ ] The old EC2 instance and VPC setup.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1463Remove review host dns record2020-01-25T17:45:08+01:00Joren VranckenRemove review host dns recordCloses #996
#### Previous behaviour
Steps to reproduce:
1. Run remove review CI job.
2. The DNS record is not removed.
#### New behaviour
Steps to validate that it works:
1. Run remove review CI job.
2. The DNS record is rem...Closes #996
#### Previous behaviour
Steps to reproduce:
1. Run remove review CI job.
2. The DNS record is not removed.
#### New behaviour
Steps to validate that it works:
1. Run remove review CI job.
2. The DNS record is removed.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1462Update dependency freezegun to v0.3.132020-02-05T12:23:31+01:00Thalia TechnicieUpdate dependency freezegun to v0.3.13This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [freezegun](https://github.com/spulec/freezegun) | dependencies | patch | `0.3.12` -> `0.3.13` |
---
### Renovate configuration
:date: *...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [freezegun](https://github.com/spulec/freezegun) | dependencies | patch | `0.3.12` -> `0.3.13` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1461Update dependency Faker to v42020-02-05T12:23:31+01:00Thalia TechnicieUpdate dependency Faker to v4This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Faker](https://github.com/joke2k/faker) | dev-dependencies | major | `3.0` -> `4.0` |
---
### Renovate configuration
:date: **Schedule*...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Faker](https://github.com/joke2k/faker) | dev-dependencies | major | `3.0` -> `4.0` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1460Increase payments coverage2020-01-25T17:45:08+01:00Sébastiaan VersteegIncrease payments coverage### Short description
Increase payments coverage to 100%. This will make sure !1450 will be mergeable.### Short description
Increase payments coverage to 100%. This will make sure !1450 will be mergeable.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1459Update django-localflavor and pin to specific versions in pyproject.toml2020-02-05T12:24:12+01:00Sébastiaan VersteegUpdate django-localflavor and pin to specific versions in pyproject.tomlThis MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [django-localflavor](https://github.com/django/django-localflavor) | dev-dependencies | major | `~2.1` -> `latest git revision` |
I ...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [django-localflavor](https://github.com/django/django-localflavor) | dev-dependencies | major | `~2.1` -> `latest git revision` |
I do not want to wait for a release, the code does seem stable as is. And this is required for django 3.0.
This MR also pins the versions in pyproject.yml so that renovate can update all, since apparently it's missing stuff.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1458Update django-compressor to v2.4.02020-02-05T12:24:10+01:00Sébastiaan VersteegUpdate django-compressor to v2.4.0This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [django-compressor](https://github.com/django-compressor/django-compressor) | dependencies | minor | `~2.2` -> `~2.4` |This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [django-compressor](https://github.com/django-compressor/django-compressor) | dependencies | minor | `~2.2` -> `~2.4` |30Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1457Added more colors for the statistics page graphs2020-01-08T22:43:26+01:00Luc KnolAdded more colors for the statistics page graphsCloses #982
#### Previous behaviour
Steps to reproduce:
1. There are not enough different colors in the statistics committee chart.
#### New behaviour
Steps to validate that it works:
1. Now there are enough colors, every c...Closes #982
#### Previous behaviour
Steps to reproduce:
1. There are not enough different colors in the statistics committee chart.
#### New behaviour
Steps to validate that it works:
1. Now there are enough colors, every committee now has its own color.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1455Fixed KeyError: 'delete_selected'2020-01-08T22:43:53+01:00Luc KnolFixed KeyError: 'delete_selected'Closes #992
#### Previous behaviour
Steps to reproduce:
1. Try to delete an event by a user without the right permissions.
#### New behaviour
Steps to validate that it works:
1. Event can be deleted.
Closes #992
#### Previous behaviour
Steps to reproduce:
1. Try to delete an event by a user without the right permissions.
#### New behaviour
Steps to validate that it works:
1. Event can be deleted.
30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1454Update dependency sentry-sdk to ~0.14.02020-02-05T12:23:31+01:00Thalia TechnicieUpdate dependency sentry-sdk to ~0.14.0This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sentry-sdk](https://github.com/getsentry/sentry-python) | dependencies | minor | `~0.13.0` -> `~0.14.0` |
---
### Renovate configuration...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sentry-sdk](https://github.com/getsentry/sentry-python) | dependencies | minor | `~0.13.0` -> `~0.14.0` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1453Black all code2020-01-07T13:00:37+01:00Luko van der MaasBlack all code### Short description
All code is blacked and black is added to ci and readme### Short description
All code is blacked and black is added to ci and readme30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1452Update dependency Pillow to v72020-02-05T12:23:31+01:00Thalia TechnicieUpdate dependency Pillow to v7This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Pillow](https://python-pillow.org) ([source](https://github.com/python-pillow/Pillow)) | dependencies | major | `~6.2` -> `~7.0` |
---
#...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Pillow](https://python-pillow.org) ([source](https://github.com/python-pillow/Pillow)) | dependencies | major | `~6.2` -> `~7.0` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1451Update dependency django-sendfile2 to v0.5.12020-02-05T12:23:31+01:00Thalia TechnicieUpdate dependency django-sendfile2 to v0.5.1This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [django-sendfile2](https://github.com/moggers87/django-sendfile2) | dependencies | minor | `0.4.3` -> `0.5.1` |
---
### Renovate configur...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [django-sendfile2](https://github.com/moggers87/django-sendfile2) | dependencies | minor | `0.4.3` -> `0.5.1` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1450Update dependency coverage to v52020-02-05T12:23:31+01:00Thalia TechnicieUpdate dependency coverage to v5This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [coverage](https://github.com/nedbat/coveragepy) | dev-dependencies | major | `4.5.4` -> `5.0.3` |
---
### Renovate configuration
:date:...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [coverage](https://github.com/nedbat/coveragepy) | dev-dependencies | major | `4.5.4` -> `5.0.3` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1449Resolve "Improve privacy policy regarding server data"2020-01-30T13:33:18+01:00Jelle Besselingjelle@pingiun.comResolve "Improve privacy policy regarding server data"This is WIP because it only has English changes, I want to gather some feedback first and then translate the changes to Dutch.This is WIP because it only has English changes, I want to gather some feedback first and then translate the changes to Dutch.30Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1448Upgrade to Django 2.2.92019-12-18T13:56:54+01:00Jelle Besselingjelle@pingiun.comUpgrade to Django 2.2.9### Short description
Upgraded Django version, as this is a high severity security release### Short description
Upgraded Django version, as this is a high severity security releasehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1447Update dependency Django to v32020-02-05T12:23:30+01:00Thalia TechnicieUpdate dependency Django to v3This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Django](https://www.djangoproject.com/) ([source](https://github.com/django/django), [changelog](https://github.com/django/django/tree...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Django](https://www.djangoproject.com/) ([source](https://github.com/django/django), [changelog](https://github.com/django/django/tree/master/docs/releases)) | dependencies | major | `2.2.9` -> `3.0.2` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1446Update dependency Faker to v32020-02-05T12:23:30+01:00Thalia TechnicieUpdate dependency Faker to v3This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Faker](https://github.com/joke2k/faker) | dev-dependencies | major | `~2.0` -> `~3.0` |
---
### Renovate configuration
:date: **Schedul...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Faker](https://github.com/joke2k/faker) | dev-dependencies | major | `~2.0` -> `~3.0` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1445Update dependency sphinx to ~2.32020-02-05T12:23:30+01:00Thalia TechnicieUpdate dependency sphinx to ~2.3This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | minor | `~2.2` -> `~2.3` |
---
### Renovate configuration
:date: **Schedule**: "every ...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | minor | `~2.2` -> `~2.3` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1444Update dependency djangorestframework to ~3.112020-02-05T12:23:30+01:00Thalia TechnicieUpdate dependency djangorestframework to ~3.11This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [djangorestframework](https://www.django-rest-framework.org/) ([changelog](https://www.django-rest-framework.org/community/release-notes/))...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [djangorestframework](https://www.django-rest-framework.org/) ([changelog](https://www.django-rest-framework.org/community/release-notes/)) | dependencies | minor | `~3.10` -> `~3.11` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30