concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2020-02-19T21:50:00+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1495Update dependency freezegun to v0.3.152020-02-19T21:50:00+01:00Thalia TechnicieUpdate dependency freezegun to v0.3.15This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [freezegun](https://github.com/spulec/freezegun) | dependencies | patch | `0.3.14` -> `0.3.15` |
:warning: Release Notes retrieval for thi...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [freezegun](https://github.com/spulec/freezegun) | dependencies | patch | `0.3.14` -> `0.3.15` |
:warning: Release Notes retrieval for this MR were skipped because no github.com credentials were available.
To add credentials for github.com to your config, please see [this guide](https://docs.renovatebot.com/install-gitlab-app/#configuring-a-token-for-githubcom-hosted-release-notes).
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1494Added a banner for members who are banned from certain or all events.2020-02-19T21:47:45+01:00Marthijn van den NieuwenhuizenAdded a banner for members who are banned from certain or all events.Closes #987
### Short description
Added a banner for people who are not allowed to register for certain events to contact thalia's treasurer for more information.
### Steps to use this feature
1. ban yourself
2. refresh page to see ...Closes #987
### Short description
Added a banner for people who are not allowed to register for certain events to contact thalia's treasurer for more information.
### Steps to use this feature
1. ban yourself
2. refresh page to see banner at the top.31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1493Add base class for all payable objects2020-02-12T21:14:49+01:00Sébastiaan VersteegAdd base class for all payable objectsCloses #1010
### Short description
Add base class for all payable objects
### Steps to use this feature
1. Use it in your codeCloses #1010
### Short description
Add base class for all payable objects
### Steps to use this feature
1. Use it in your code31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1492Resolve "/api/v1/token-auth does not return json on login failure"2020-02-20T08:45:53+01:00Simcha van CollemResolve "/api/v1/token-auth does not return json on login failure"Closes #975
#### Previous behaviour
Steps to reproduce:
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
#### New behaviour
Steps to validate that it works:
1. Post wrong credentials to `/api/v1/token-...Closes #975
#### Previous behaviour
Steps to reproduce:
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
#### New behaviour
Steps to validate that it works:
1. Post wrong credentials to `/api/v1/token-auth`
2. `{"error": "Unauthorized"}` is returned31Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1491Add information on sentry.io to privacy policy2020-03-04T22:03:48+01:00Jelle Besselingjelle@pingiun.comAdd information on sentry.io to privacy policyThe privacy policy now includes information on the data collected and sent to sentry.ioThe privacy policy now includes information on the data collected and sent to sentry.iohttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1490Update dependency sphinx to v2.4.22020-02-19T21:49:59+01:00Thalia TechnicieUpdate dependency sphinx to v2.4.2This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | patch | `2.4.0` -> `2.4.2` |
---
### Renovate configuration
:date: **Schedule**: "ever...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | patch | `2.4.0` -> `2.4.2` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1489Update dependency sphinx to v2.4.02020-02-19T21:50:19+01:00Thalia TechnicieUpdate dependency sphinx to v2.4.0This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | minor | `2.3.1` -> `2.4.0` |
---
### Renovate configuration
:date: **Schedule**: "ever...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sphinx](http://sphinx-doc.org/) | dependencies | minor | `2.3.1` -> `2.4.0` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1488Create dependencies Docker image2020-02-08T22:06:54+01:00Joren VranckenCreate dependencies Docker image### Description
The goal of this MR is to create a new Docker image that contains all the dependencies of Concrexit. This image would be built using a Gitlab CI Pipeline schedule.
With this change the following would happen:
- Every...### Description
The goal of this MR is to create a new Docker image that contains all the dependencies of Concrexit. This image would be built using a Gitlab CI Pipeline schedule.
With this change the following would happen:
- Every day (or on some other schedule) a new Docker image containing only the dependencies (including the development dependencies) is being build.
- The CI jobs run using the dependencies image. This removes the dependency install time from every job.
- `poetry install` is still being run on every job, to make sure dependencies specific to that branch are being installed.
- A Docker image (`concrexit:<sha>`) is being build on every branch, but significantly faster because the dependencies image is used as the base image.
- When a production Docker is being built, a new dependencies image without the development dependencies is build first.
The advantages:
- Faster builds.
- Always build using up to date dependencies ([thaliawww/python-thalia](https://github.com/thaliawww/python-thalia) is not automatically build and updated).
- Better maintainable configuration, because everything is in this repo instead of two repos on two different platforms.
Because a lot of refactoring is being done, this MR also refactors the whole config to be consistent. 31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1487Don't build Docker image using docker-compose2020-02-19T21:50:24+01:00Joren VranckenDon't build Docker image using docker-compose### Short description
Do not use `docker-compose` to build the Docker image.
This removes the need for the (very outdated) [`thalia/docker-compose` image](https://hub.docker.com/r/thalia/docker-compose) and [thaliawww/docker-dockerco...### Short description
Do not use `docker-compose` to build the Docker image.
This removes the need for the (very outdated) [`thalia/docker-compose` image](https://hub.docker.com/r/thalia/docker-compose) and [thaliawww/docker-dockercompose repository](https://github.com/thaliawww/docker-dockercompose).31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1486Login page not visible anymore when logged-in2020-02-05T21:24:02+01:00Luc KnolLogin page not visible anymore when logged-inCloses #979
#### Previous behaviour
Steps to reproduce:
1. log in
2. visit thalia.nu/user/login
#### New behaviour
Steps to validate that it works:
1. log in
2. visit thalia.nu/user/login
3. get redirected to homeCloses #979
#### Previous behaviour
Steps to reproduce:
1. log in
2. visit thalia.nu/user/login
#### New behaviour
Steps to validate that it works:
1. log in
2. visit thalia.nu/user/login
3. get redirected to home31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1485Resolve "'All members' in members directory not marked as active"2020-02-05T21:18:38+01:00Simcha van CollemResolve "'All members' in members directory not marked as active"Closes #1004
#### Previous behaviour
Steps to reproduce:
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
#### New behaviour
Steps to validate that it works:
1. Go to https://thalia.nu/members/directory/
2. ...Closes #1004
#### Previous behaviour
Steps to reproduce:
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
#### New behaviour
Steps to validate that it works:
1. Go to https://thalia.nu/members/directory/
2. The item is selected31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1484Fix poetry install method2020-02-05T21:04:41+01:00Sébastiaan VersteegFix poetry install methodhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1482Success_messages added for every exam and summary upload2020-02-05T21:35:25+01:00Marthijn van den NieuwenhuizenSuccess_messages added for every exam and summary uploadCloses #998
#### Previous behaviour
Steps to reproduce:
1. Upload Exam or Summary
2. Receive no notification message upon successful upload
#### New behaviour
Steps to validate that it works:
1. Upload Exam or Summary
2. Receive not...Closes #998
#### Previous behaviour
Steps to reproduce:
1. Upload Exam or Summary
2. Receive no notification message upon successful upload
#### New behaviour
Steps to validate that it works:
1. Upload Exam or Summary
2. Receive notification message upon successful upload31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1481Resolve "No favicon for the admin site"2020-02-05T21:24:49+01:00Wouter DoelandResolve "No favicon for the admin site"/label ~bug
Closes #999
#### Previous behaviour
Steps to reproduce:
1. Open the admin panel
2. There is no favicon
#### New behaviour
Steps to validate that it works:
1. Open the admin panel
2. There is a favicon
/label ~bug
Closes #999
#### Previous behaviour
Steps to reproduce:
1. Open the admin panel
2. There is no favicon
#### New behaviour
Steps to validate that it works:
1. Open the admin panel
2. There is a favicon
31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1480Add dark mode styling2020-03-04T21:54:01+01:00Sébastiaan VersteegAdd dark mode styling/label ~feature
Closes #953
### Short description
Add dark mode styling
### Steps to use this feature
1. Enable dark mode on your computer
/label ~feature
Closes #953
### Short description
Add dark mode styling
### Steps to use this feature
1. Enable dark mode on your computer
31Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1479Update dependency Django to v3.0.32020-02-19T20:02:34+01:00Thalia TechnicieUpdate dependency Django to v3.0.3This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Django](https://www.djangoproject.com/) ([source](https://github.com/django/django), [changelog](https://github.com/django/django/tree/mas...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Django](https://www.djangoproject.com/) ([source](https://github.com/django/django), [changelog](https://github.com/django/django/tree/master/docs/releases)) | dependencies | patch | `3.0.2` -> `3.0.3` |
:warning: Release Notes retrieval for this MR were skipped because no github.com credentials were available.
To add credentials for github.com to your config, please see [this guide](https://docs.renovatebot.com/install-gitlab-app/#configuring-a-token-for-githubcom-hosted-release-notes).
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1478Revert "Merge branch 'add-dark-color-scheme' into 'master'"2020-02-27T09:36:09+01:00Luko van der MaasRevert "Merge branch 'add-dark-color-scheme' into 'master'"This reverts merge request !1413This reverts merge request !1413https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1477Move review CI jobs to separate sh files2020-01-30T13:33:19+01:00Joren VranckenMove review CI jobs to separate sh files### Description
This MR refactors the large complex CI jobs that create and remove the review hosts into Bash scripts.
This has multiple advantages:
- No more complex Bash in Yaml (e.g. a heredoc in a multiline Yaml item).
- Only execut...### Description
This MR refactors the large complex CI jobs that create and remove the review hosts into Bash scripts.
This has multiple advantages:
- No more complex Bash in Yaml (e.g. a heredoc in a multiline Yaml item).
- Only executing tasks when needed instead of of using `x | true`.
- Smaller, more readable CI config.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1476Remove old Pylint and flake8 references2020-01-30T13:33:19+01:00Joren VranckenRemove old Pylint and flake8 references### Short description
Remove old Pylint and flake8 references, because both have been replaced by Black.### Short description
Remove old Pylint and flake8 references, because both have been replaced by Black.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1475Move coverage.py settings to pyproject.toml2020-01-30T13:38:40+01:00Joren VranckenMove coverage.py settings to pyproject.toml### Description
Move `coverage.py` settings to `pyproject.toml`.
`python -Wall` is removed because the warnings it produces are non-critical and mostly out of our control. It, however, does make the CI logs a lot less legible.### Description
Move `coverage.py` settings to `pyproject.toml`.
`python -Wall` is removed because the warnings it produces are non-critical and mostly out of our control. It, however, does make the CI logs a lot less legible.30