concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-08-28T16:18:09+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/879Use pipenv instead of requirements.txt2018-08-28T16:18:09+02:00Thom WiggersUse pipenv instead of requirements.txtCloses #672, #631
### Short description
* Use pipenv instead of requirements.txt
* Easier usage of virtual envs
* Easier handling of dev environments (`pipenv install --dev`)
* Supersedes pipconflictchecker (thus closes #631)
* Supers...Closes #672, #631
### Short description
* Use pipenv instead of requirements.txt
* Easier usage of virtual envs
* Easier handling of dev environments (`pipenv install --dev`)
* Supersedes pipconflictchecker (thus closes #631)
* Supersedes `safety` (integrated in `pipenv check`)
### Todo
* [x] Fix tests
* [x] Delete requirements.txt
* [x] Update docs
* [x] Figure out how `pipenv check` handles `python_version` (https://github.com/pypa/pipenv/issues/2694)
* [x] Fix docker build
* [x] https://github.com/thaliawww/python-thalia/pull/1
* [x] https://github.com/thaliawww/python-thalia/pull/2
### Caveats
* This does get rid of the separate `production-requirements.txt` and thus may require installing more C libraries (`argon2`, `postgresql`) on development systems. On the other hand, production and development will be much closer.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/730Use Orientation EXIF tag in photo to determine orientation on upload2018-03-10T12:15:58+01:00Sébastiaan VersteegUse Orientation EXIF tag in photo to determine orientation on uploadCloses #591
### Short description
Use Orientation EXIF tag in photo to determine orientation on upload
### Steps to use this feature
1. Upload a photo that has the orientation saved in the EXIf info. If you don't have one, as...Closes #591
### Short description
Use Orientation EXIF tag in photo to determine orientation on upload
### Steps to use this feature
1. Upload a photo that has the orientation saved in the EXIf info. If you don't have one, ask me.
2. Upload and save the photo.
3. The orientation should be translated to the right rotation value in the Photo object.1.14https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1315Use new PARTNER_NOTIFICATION_ADDRESS instead of old PARTNER_EMAIL2019-08-01T13:43:05+02:00Joren VranckenUse new PARTNER_NOTIFICATION_ADDRESS instead of old PARTNER_EMAIL`PARTNER_EMAIL` was replaced in a393f6e9ec591cd61991fd888729bf3cd0140d78 by `PARTNER_NOTIFICATION_ADDRESS`.
#### Previous behaviour
Steps to reproduce:
[Sentry Issue](https://sentry.io/organizations/thalia/issues/1134801598/?project=147...`PARTNER_EMAIL` was replaced in a393f6e9ec591cd61991fd888729bf3cd0140d78 by `PARTNER_NOTIFICATION_ADDRESS`.
#### Previous behaviour
Steps to reproduce:
[Sentry Issue](https://sentry.io/organizations/thalia/issues/1134801598/?project=1470866)Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/433Use newer version of flake82017-04-05T21:50:55+02:00Thom WiggersUse newer version of flake8We pinned a specific version of flake8 a while back, but now we should use the latest version again. Also fixes some (minor) issues the old version didn't see.We pinned a specific version of flake8 a while back, but now we should use the latest version again. Also fixes some (minor) issues the old version didn't see.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1523Use new coverage url in README2020-03-09T22:40:41+01:00Joren VranckenUse new coverage url in README### Short description
Use new coverage url in README.### Short description
Use new coverage url in README.31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/618Use more specific exceptions and include context2017-12-27T23:18:56+01:00Thom WiggersUse more specific exceptions and include contextResolves discussions in !617Resolves discussions in !6171.12Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1017Use member.profile.display_name instead of member.display_name for profile im...2018-11-05T20:10:28+01:00Joren VranckenUse member.profile.display_name instead of member.display_name for profile images alt attribute#### Previous behaviour
Steps to reproduce:
1. Go to user profile page.
2. Look at `alt` attribute of the profile image.
3. It is not the `display_name`.
#### New behaviour
Steps to validate that it works:
1. Go to user profile page.
...#### Previous behaviour
Steps to reproduce:
1. Go to user profile page.
2. Look at `alt` attribute of the profile image.
3. It is not the `display_name`.
#### New behaviour
Steps to validate that it works:
1. Go to user profile page.
2. Look at `alt` attribute of the profile image.
3. It is the `display_name` (or the username if there is no `display_name`).19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/359Use lecture year for documents2017-03-08T20:35:50+01:00Sébastiaan VersteegUse lecture year for documentsFix #328Fix #328https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/64Use ID instead of fragile year2016-10-05T19:32:54+02:00Thom WiggersUse ID instead of fragile yearCloses #69Closes #69LaunchSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/629Use get for dict access in order serializer2017-12-27T23:17:27+01:00Tom van BusselUse get for dict access in order serializerCloses no issue
#### Previous behaviour
Steps to reproduce:
1. Create an order through /api/v1/pizzas/orders without specifying name or member
2. Crash
#### New behaviour
Steps to validate that it works:
1. Create an order through /a...Closes no issue
#### Previous behaviour
Steps to reproduce:
1. Create an order through /api/v1/pizzas/orders without specifying name or member
2. Crash
#### New behaviour
Steps to validate that it works:
1. Create an order through /api/v1/pizzas/orders without specifying name or member
2. It works1.12https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1018Use fstrings in edu views.py2018-10-24T23:28:09+02:00Sébastiaan VersteegUse fstrings in edu views.py### Short description
Use fstrings in edu views.py### Short description
Use fstrings in edu views.py19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/628Use DRF's get_object_or_404 instead of the default in the pizzas viewset2017-12-20T19:23:33+01:00Sébastiaan VersteegUse DRF's get_object_or_404 instead of the default in the pizzas viewset### Short description
The error should be given in JSON, not HTML.### Short description
The error should be given in JSON, not HTML.1.12https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1126Use Docker hub image name instead of Gitlab registry image name2019-01-13T23:02:54+01:00Joren VranckenUse Docker hub image name instead of Gitlab registry image name### Short description
Use Docker hub image name instead of Gitlab registry image name### Short description
Use Docker hub image name instead of Gitlab registry image namehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/670Use docker container from own namespace2018-01-17T21:49:57+01:00Thom WiggersUse docker container from own namespaceUse the docker from thalia's own hub group.Use the docker from thalia's own hub group.1.13https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/892Use correct english names of studies (and translate "Access the Sentry backend")2018-08-28T17:28:11+02:00Joren VranckenUse correct english names of studies (and translate "Access the Sentry backend")### Short description
- "[Cc]omputer [Ss]cience" -> "Computing Science"
- "[Ii]nformation [Ss]cience" -> "Information Sciences"
- Translates "Access the Sentry backend"### Short description
- "[Cc]omputer [Ss]cience" -> "Computing Science"
- "[Ii]nformation [Ss]cience" -> "Information Sciences"
- Translates "Access the Sentry backend"1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/515Use bleach to prevent escaped characters in event card2017-06-28T19:54:41+02:00Sébastiaan VersteegUse bleach to prevent escaped characters in event cardCloses #446
#### Previous behaviour
Steps to reproduce:
1. Open thalia.nu
2. Scroll naar beneden naar "Aankomende evenementen"
3. ` ` in text
#### New behaviour
Steps to validate that it works:
1. Open thalia.nu
2....Closes #446
#### Previous behaviour
Steps to reproduce:
1. Open thalia.nu
2. Scroll naar beneden naar "Aankomende evenementen"
3. ` ` in text
#### New behaviour
Steps to validate that it works:
1. Open thalia.nu
2. Scroll naar beneden naar "Aankomende evenementen"
3. ` ` is unescaped in texthttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/207Use a thumbnail in the member directory2016-12-06T17:57:05+01:00Sébastiaan VersteegUse a thumbnail in the member directoryhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/721Use app configs2018-02-12T14:43:14+01:00Thom WiggersUse app configsThe Django docs recommend to specify the `AppConfig` explicitly in the `INSTALLED_APPS` setting: https://docs.djangoproject.com/en/2.0/ref/applications/#for-application-authors.
This MR also completes the translations, some of which wer...The Django docs recommend to specify the `AppConfig` explicitly in the `INSTALLED_APPS` setting: https://docs.djangoproject.com/en/2.0/ref/applications/#for-application-authors.
This MR also completes the translations, some of which were lacking.1.14https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/647Use anonymous volume to cache docs build if not mounted2018-01-11T23:47:20+01:00Thom WiggersUse anonymous volume to cache docs build if not mounted1.13https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/222Use advanced TinyMCE to make sure you can add hyperlinks2016-12-07T17:59:42+01:00Sébastiaan VersteegUse advanced TinyMCE to make sure you can add hyperlinksCloses #210Closes #210