concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2020-02-05T12:23:30+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1444Update dependency djangorestframework to ~3.112020-02-05T12:23:30+01:00Thalia TechnicieUpdate dependency djangorestframework to ~3.11This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [djangorestframework](https://www.django-rest-framework.org/) ([changelog](https://www.django-rest-framework.org/community/release-notes/))...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [djangorestframework](https://www.django-rest-framework.org/) ([changelog](https://www.django-rest-framework.org/community/release-notes/)) | dependencies | minor | `~3.10` -> `~3.11` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1431Order the Pizza Events on the order date2020-02-05T12:25:53+01:00Joren VranckenOrder the Pizza Events on the order date### Short description
Order the Pizza Events on the order date.### Short description
Order the Pizza Events on the order date.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1448Upgrade to Django 2.2.92019-12-18T13:56:54+01:00Jelle Besselingjelle@pingiun.comUpgrade to Django 2.2.9### Short description
Upgraded Django version, as this is a high severity security release### Short description
Upgraded Django version, as this is a high severity security releasehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1440Fix start reminder users slicing2019-12-13T15:41:54+01:00Sébastiaan VersteegFix start reminder users slicingCloses #989
#### Previous behaviour
Steps to reproduce:
1. Create an event with participants
2. Crash on save
#### New behaviour
Steps to validate that it works:
1. Create an event with participants
2. No crash on saveCloses #989
#### Previous behaviour
Steps to reproduce:
1. Create an event with participants
2. Crash on save
#### New behaviour
Steps to validate that it works:
1. Create an event with participants
2. No crash on savehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1437Fix G Suite env variable and profile option2019-12-05T13:24:25+01:00Sébastiaan VersteegFix G Suite env variable and profile option#### Previous behaviour
Steps to reproduce:
1. It syncs `thalia.nu` in mailinglists instead of the members domain because the env variable is wrong
2. The profile option for G Suite is missing
#### New behaviour
Steps to validat...#### Previous behaviour
Steps to reproduce:
1. It syncs `thalia.nu` in mailinglists instead of the members domain because the env variable is wrong
2. The profile option for G Suite is missing
#### New behaviour
Steps to validate that it works:
1. It syncs using the right domain
2. The profile option is availablehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1436Fix small issues with G Suite member sync2019-12-04T21:50:56+01:00Sébastiaan VersteegFix small issues with G Suite member syncFound during testing.Found during testing.29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1433Split sent_date migrations for push notifications2019-12-03T10:29:01+01:00Sébastiaan VersteegSplit sent_date migrations for push notifications#### Previous behaviour
Steps to reproduce:
1. Non working migrations on staging
#### New behaviour
Steps to validate that it works:
1. working migrations on staging#### Previous behaviour
Steps to reproduce:
1. Non working migrations on staging
#### New behaviour
Steps to validate that it works:
1. working migrations on staginghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1432Revert "Merge branch 'review-git-strategy-none' into 'master'"2019-12-02T23:26:08+01:00Sébastiaan VersteegRevert "Merge branch 'review-git-strategy-none' into 'master'"This reverts merge request !1429This reverts merge request !1429https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1360Cannot fill in field for guest registration2019-12-02T22:39:00+01:00Luko van der MaasCannot fill in field for guest registration~bug
Closes #925
#### Previous behaviour
Steps to reproduce:
1. create an event with registration fields
2. add a registration with a name
3. try to change the field
4. nothings happens
#### New behaviour
Steps to valid...~bug
Closes #925
#### Previous behaviour
Steps to reproduce:
1. create an event with registration fields
2. add a registration with a name
3. try to change the field
4. nothings happens
#### New behaviour
Steps to validate that it works:
1. create an event with registration fields
2. add a registration with a name
3. try to change the field
4. it is changed
29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1429Add git strategy none to gitlab-ci2019-12-02T23:17:12+01:00Sébastiaan VersteegAdd git strategy none to gitlab-ci#### Previous behaviour
Steps to reproduce:
1. Review stop not working
#### New behaviour
Steps to validate that it works:
1. Review stop working#### Previous behaviour
Steps to reproduce:
1. Review stop not working
#### New behaviour
Steps to validate that it works:
1. Review stop working29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1396Sync active members with G Suite2019-11-27T20:32:14+01:00Sébastiaan VersteegSync active members with G SuiteCloses #945 #876 #958 #952
### Short description
Sync active members with G Suite
### Steps to use this feature
1. Run the new `init_gsuite_users` management command to populate the initial G Suite users
2. Now remove the ...Closes #945 #876 #958 #952
### Short description
Sync active members with G Suite
### Steps to use this feature
1. Run the new `init_gsuite_users` management command to populate the initial G Suite users
2. Now remove the group memberships or add membership for any user and see that these users get suspended or created
3. Run the `delete_gsuite_users` management command to permanently delete the suspended users
Note that during init and delete the member should receive an email. If the member becomes an active member again (which is equal to `is_staff` after suspension they will receive an email as well with the password value being 'known by the user'.
29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1392Edited event slide functionality to be able to display slides specific to cer...2019-11-20T22:07:13+01:00Luc KnolEdited event slide functionality to be able to display slides specific to certain eventsCloses #820
### Short description
Edited event slide functionality to be able to display slides specific to certain events
### Steps to use this feature
1. Administration > events > events > Add Event
2. Select a slide from the "sli...Closes #820
### Short description
Edited event slide functionality to be able to display slides specific to certain events
### Steps to use this feature
1. Administration > events > events > Add Event
2. Select a slide from the "slide:" field
3. This slide is visible at the events info-page and is added to the homepage slides29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1417Add review environment2019-11-27T20:32:15+01:00Jelle Besselingjelle@pingiun.comAdd review environment29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1428Events on personal ical feed are now excluded if someone deregistered2019-11-20T21:39:38+01:00Simcha van CollemEvents on personal ical feed are now excluded if someone deregisteredCloses #963
#### Previous behaviour
Steps to reproduce:
1. Deregister from event
2. Download personal iCal feed
3. See the event despite you deregistered
#### New behaviour
Steps to validate that it works:
1. Deregister from event...Closes #963
#### Previous behaviour
Steps to reproduce:
1. Deregister from event
2. Download personal iCal feed
3. See the event despite you deregistered
#### New behaviour
Steps to validate that it works:
1. Deregister from event
2. Download personal iCal feed
3. No event there29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1427Fixed JS-Charts X-Axis in members-statistics2019-11-27T20:32:15+01:00Marthijn van den NieuwenhuizenFixed JS-Charts X-Axis in members-statisticsCloses #950
#### Previous behaviour
Steps to reproduce:
1. open Statistics
2. See missing statistic names on x-axis
#### New behaviour
Steps to validate that it works:
1. op Statistics
2. See no missing statistic names on x-axisCloses #950
#### Previous behaviour
Steps to reproduce:
1. open Statistics
2. See missing statistic names on x-axis
#### New behaviour
Steps to validate that it works:
1. op Statistics
2. See no missing statistic names on x-axis29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1425Add docs to pizzas package2019-11-27T20:32:15+01:00Sébastiaan VersteegAdd docs to pizzas packageCloses #582
### Short description
Add docs to pizzas packageCloses #582
### Short description
Add docs to pizzas package29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1423Remove test run in docker build2019-11-27T20:32:15+01:00Jelle Besselingjelle@pingiun.comRemove test run in docker buildCloses #949
### Short description
Tests already run in a separate stage so they don't need to run in the docker buildCloses #949
### Short description
Tests already run in a separate stage so they don't need to run in the docker build29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1422Update dependency firebase-admin to ~3.22019-11-16T13:16:13+01:00Thalia TechnicieUpdate dependency firebase-admin to ~3.2This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [firebase-admin](https://firebase.google.com/docs/admin/setup/) ([changelog](https://firebase.google.com/support/release-notes/admin/python...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [firebase-admin](https://firebase.google.com/docs/admin/setup/) ([changelog](https://firebase.google.com/support/release-notes/admin/python)) | dependencies | minor | `~3.1` -> `~3.2` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- renovate-rebase -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://renovatebot.com).29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1420Change the euro sign encoding in newsletters2019-11-13T22:00:35+01:00Luna-Elise SchernthanerChange the euro sign encoding in newslettersCloses #960
#### Previous behaviour
Steps to reproduce:
1. Create a newsletter with an event that has a price or cancellation fee.
2. Send this newsletter to members.
3. The euro sign is not displayed correctly in the received ...Closes #960
#### Previous behaviour
Steps to reproduce:
1. Create a newsletter with an event that has a price or cancellation fee.
2. Send this newsletter to members.
3. The euro sign is not displayed correctly in the received newsletter.
#### New behaviour
Steps to validate that it works:
1. Create a newsletter with an event that has a price or cancellation fee.
2. Send this newsletter to members.
3. The euro sign is displayed correctly in the received newsletter. 29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1375Fixed creating group membership without filling in required field 'member' or...2019-11-13T21:59:18+01:00Marthijn van den NieuwenhuizenFixed creating group membership without filling in required field 'member' or 'group'Closes #910
#### Previous behaviour
Steps to reproduce:
1. Create a group membership without filling in either a name or a group
2. breakage
#### New behaviour
Steps to validate that it works:
1. Create a group membership...Closes #910
#### Previous behaviour
Steps to reproduce:
1. Create a group membership without filling in either a name or a group
2. breakage
#### New behaviour
Steps to validate that it works:
1. Create a group membership without filling in either a name or a group
2. Receive error message29