concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2020-01-30T13:33:19+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1474Use Python 3.82020-01-30T13:33:19+01:00Joren VranckenUse Python 3.8### Short description
Use Python 3.8### Short description
Use Python 3.830https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1473Move static coverage and docs sites to S32020-01-30T13:33:19+01:00Joren VranckenMove static coverage and docs sites to S3### Description
Move static coverage and docs sites to S3.
I have created the following AWS service instances:
- Two S3 buckets, called `thalia-coverage` and `thalia-documentation`.
- A policy that allows the `gitlab-deploy` user (...### Description
Move static coverage and docs sites to S3.
I have created the following AWS service instances:
- Two S3 buckets, called `thalia-coverage` and `thalia-documentation`.
- A policy that allows the `gitlab-deploy` user (who is also used to deploy the review environment) to manage files in those buckets.30Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1472Replace Nextcloud menu item with G Suite Knowledge Base2020-02-19T19:55:43+01:00Joren VranckenReplace Nextcloud menu item with G Suite Knowledge Base### Short description
Replace Nextcloud menu item with G Suite Knowledge Base, because we will shutdown Nextcloud on February 3rd in favor of G Suite.### Short description
Replace Nextcloud menu item with G Suite Knowledge Base, because we will shutdown Nextcloud on February 3rd in favor of G Suite.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1471Use timezone aware date2020-02-05T12:37:15+01:00Joren VranckenUse timezone aware date### Short description
Fix the following warning in `PaymentListViewTest`:
```
RuntimeWarning: DateTimeField Payment.processing_date received a naive datetime (2019-03-06 00:00:00) while time zone support is active.
```### Short description
Fix the following warning in `PaymentListViewTest`:
```
RuntimeWarning: DateTimeField Payment.processing_date received a naive datetime (2019-03-06 00:00:00) while time zone support is active.
```30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1470Add ordering to fix UnorderedObjectListWarning warnings2020-02-05T12:35:58+01:00Joren VranckenAdd ordering to fix UnorderedObjectListWarning warnings### Short description
Add ordering to fix `UnorderedObjectListWarning` warnings.### Short description
Add ordering to fix `UnorderedObjectListWarning` warnings.30Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1469Update dependency freezegun to v0.3.142020-02-05T12:23:32+01:00Thalia TechnicieUpdate dependency freezegun to v0.3.14This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [freezegun](https://github.com/spulec/freezegun) | dependencies | patch | `0.3.13` -> `0.3.14` |
---
### Renovate configuration
:date: *...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [freezegun](https://github.com/spulec/freezegun) | dependencies | patch | `0.3.13` -> `0.3.14` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1468Make registration deadline, cancellation deadline, and number of registration...2020-01-25T17:45:09+01:00Luna-Elise SchernthanerMake registration deadline, cancellation deadline, and number of registrations...Closes #919
#### Previous behaviour
Steps to reproduce:
1. View an event with a registration deadline, cancellation deadline, and a number of registrations on thalia.nu without logging in.
2. You can see the registration deadline, canc...Closes #919
#### Previous behaviour
Steps to reproduce:
1. View an event with a registration deadline, cancellation deadline, and a number of registrations on thalia.nu without logging in.
2. You can see the registration deadline, cancellation deadline, and the number of registrations.
#### New behaviour
Steps to validate that it works:
1. View an event with a registration deadline, cancellation deadline, and a number of registrations on thalia.nu without logging in.
2. You cannot see the registration deadline, cancellation deadline, and the number of registrations.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1466Update dependency files2020-01-25T17:45:09+01:00Sébastiaan VersteegUpdate dependency files### Short description
Update dependency files. Specifically the ones deeper in the deptree and django-libsass because it is not detected by renovate.### Short description
Update dependency files. Specifically the ones deeper in the deptree and django-libsass because it is not detected by renovate.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1465Update dependency sentry-sdk to v0.14.12020-02-05T12:23:31+01:00Thalia TechnicieUpdate dependency sentry-sdk to v0.14.1This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sentry-sdk](https://github.com/getsentry/sentry-python) | dependencies | patch | `0.14.0` -> `0.14.1` |
---
### Renovate configuration
...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sentry-sdk](https://github.com/getsentry/sentry-python) | dependencies | patch | `0.14.0` -> `0.14.1` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted, or if you tick the rebase/retry checkbox below.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1464Setup review hosts in private subnet2020-01-25T17:45:08+01:00Joren VranckenSetup review hosts in private subnetCloses #997
### Description
This merge requests does the following:
- It uses a new version of the EC2 instance template. The new template creates instances in a private subnet. Instances do not get a public IPv4 address anymore...Closes #997
### Description
This merge requests does the following:
- It uses a new version of the EC2 instance template. The new template creates instances in a private subnet. Instances do not get a public IPv4 address anymore.
- It replaces the use of `.reviewhost` domains with `*.public.review.technicie.nl` and `*.private.review.technicie.nl` domains. `*.public.review.technicie.nl` points to `refter` (a server that acts as a NAT gateway from the public subnet to the private subnet). `*.private.review.technicie.nl` points to private IPv4 addresses within the private review subnet.
`refter` has the following `nginx` config to route the HTTP traffic:
```
server {
listen 80 default_server;
listen [::]:80 default_server;
server_name _;
return 301 https://$host$request_uri;
}
server {
listen 443 ssl http2 default_server;
listen [::]:443 ssl http2 default_server;
server_name _;
ssl on;
ssl_certificate /etc/letsencrypt/live/public.review.technicie.nl/fullchain.pem;
ssl_certificate_key /etc/letsencrypt/live/public.review.technicie.nl/privkey.pem;
return 404;
}
server {
listen 443;
listen [::]:443;
server_name "~^(?<mr_slug>[-a-z0-9]{1,63})\.public\.review\.technicie\.nl$";
ssl on;
ssl_certificate /etc/letsencrypt/live/public.review.technicie.nl/fullchain.pem;
ssl_certificate_key /etc/letsencrypt/live/public.review.technicie.nl/privkey.pem;
location / {
resolver 127.0.0.53;
proxy_pass http://$mr_slug.private.review.technicie.nl$request_uri;
}
}
```
- HTTPS does not seem to be working correctly in the current setup (for me atleast). This MR does work with HTTPS.
After this is merged. The following things should be cleaned up:
- [ ] The IAM users and policies that are not used anymore.
- [ ] The `.reviewhost` hosted zone in Route 53.
- [ ] The old EC2 instance and VPC setup.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1463Remove review host dns record2020-01-25T17:45:08+01:00Joren VranckenRemove review host dns recordCloses #996
#### Previous behaviour
Steps to reproduce:
1. Run remove review CI job.
2. The DNS record is not removed.
#### New behaviour
Steps to validate that it works:
1. Run remove review CI job.
2. The DNS record is rem...Closes #996
#### Previous behaviour
Steps to reproduce:
1. Run remove review CI job.
2. The DNS record is not removed.
#### New behaviour
Steps to validate that it works:
1. Run remove review CI job.
2. The DNS record is removed.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1462Update dependency freezegun to v0.3.132020-02-05T12:23:31+01:00Thalia TechnicieUpdate dependency freezegun to v0.3.13This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [freezegun](https://github.com/spulec/freezegun) | dependencies | patch | `0.3.12` -> `0.3.13` |
---
### Renovate configuration
:date: *...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [freezegun](https://github.com/spulec/freezegun) | dependencies | patch | `0.3.12` -> `0.3.13` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1461Update dependency Faker to v42020-02-05T12:23:31+01:00Thalia TechnicieUpdate dependency Faker to v4This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Faker](https://github.com/joke2k/faker) | dev-dependencies | major | `3.0` -> `4.0` |
---
### Renovate configuration
:date: **Schedule*...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Faker](https://github.com/joke2k/faker) | dev-dependencies | major | `3.0` -> `4.0` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1460Increase payments coverage2020-01-25T17:45:08+01:00Sébastiaan VersteegIncrease payments coverage### Short description
Increase payments coverage to 100%. This will make sure !1450 will be mergeable.### Short description
Increase payments coverage to 100%. This will make sure !1450 will be mergeable.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1459Update django-localflavor and pin to specific versions in pyproject.toml2020-02-05T12:24:12+01:00Sébastiaan VersteegUpdate django-localflavor and pin to specific versions in pyproject.tomlThis MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [django-localflavor](https://github.com/django/django-localflavor) | dev-dependencies | major | `~2.1` -> `latest git revision` |
I ...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [django-localflavor](https://github.com/django/django-localflavor) | dev-dependencies | major | `~2.1` -> `latest git revision` |
I do not want to wait for a release, the code does seem stable as is. And this is required for django 3.0.
This MR also pins the versions in pyproject.yml so that renovate can update all, since apparently it's missing stuff.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1458Update django-compressor to v2.4.02020-02-05T12:24:10+01:00Sébastiaan VersteegUpdate django-compressor to v2.4.0This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [django-compressor](https://github.com/django-compressor/django-compressor) | dependencies | minor | `~2.2` -> `~2.4` |This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [django-compressor](https://github.com/django-compressor/django-compressor) | dependencies | minor | `~2.2` -> `~2.4` |30Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1457Added more colors for the statistics page graphs2020-01-08T22:43:26+01:00Luc KnolAdded more colors for the statistics page graphsCloses #982
#### Previous behaviour
Steps to reproduce:
1. There are not enough different colors in the statistics committee chart.
#### New behaviour
Steps to validate that it works:
1. Now there are enough colors, every c...Closes #982
#### Previous behaviour
Steps to reproduce:
1. There are not enough different colors in the statistics committee chart.
#### New behaviour
Steps to validate that it works:
1. Now there are enough colors, every committee now has its own color.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1455Fixed KeyError: 'delete_selected'2020-01-08T22:43:53+01:00Luc KnolFixed KeyError: 'delete_selected'Closes #992
#### Previous behaviour
Steps to reproduce:
1. Try to delete an event by a user without the right permissions.
#### New behaviour
Steps to validate that it works:
1. Event can be deleted.
Closes #992
#### Previous behaviour
Steps to reproduce:
1. Try to delete an event by a user without the right permissions.
#### New behaviour
Steps to validate that it works:
1. Event can be deleted.
30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1454Update dependency sentry-sdk to ~0.14.02020-02-05T12:23:31+01:00Thalia TechnicieUpdate dependency sentry-sdk to ~0.14.0This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sentry-sdk](https://github.com/getsentry/sentry-python) | dependencies | minor | `~0.13.0` -> `~0.14.0` |
---
### Renovate configuration...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sentry-sdk](https://github.com/getsentry/sentry-python) | dependencies | minor | `~0.13.0` -> `~0.14.0` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box
---
This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1453Black all code2020-01-07T13:00:37+01:00Luko van der MaasBlack all code### Short description
All code is blacked and black is added to ci and readme### Short description
All code is blacked and black is added to ci and readme30