concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-11-13T21:58:58+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1390EmailMultiAlternatives added: Html version of information check email2019-11-13T21:58:58+01:00Marthijn van den NieuwenhuizenEmailMultiAlternatives added: Html version of information check emailCloses #937
### Short description
Added a HTML version of the information check email
### Steps to use this feature
1. Send information check emailCloses #937
### Short description
Added a HTML version of the information check email
### Steps to use this feature
1. Send information check email29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1419Set verbosity on console to WARNING2019-11-13T22:00:53+01:00Jelle Besselingjelle@pingiun.comSet verbosity on console to WARNINGThis will silence INFO in the console when running manage.py commands,
the INFO logs are still saved in the log file.This will silence INFO in the console when running manage.py commands,
the INFO logs are still saved in the log file.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1414Fix payments test failing at midnight2019-11-13T22:01:47+01:00Sébastiaan VersteegFix payments test failing at midnight29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1410Add mailinglists for newsletter receivers and refactor mailinglists services2019-11-13T22:00:53+01:00Sébastiaan VersteegAdd mailinglists for newsletter receivers and refactor mailinglists servicesCloses #947
### Short description
Add mailinglists for newsletter receivers and refactor mailinglists services
### Steps to use this feature
1. Sync mailinglistsCloses #947
### Short description
Add mailinglists for newsletter receivers and refactor mailinglists services
### Steps to use this feature
1. Sync mailinglistshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1418Add minimum coverage level2019-11-13T22:01:48+01:00Sébastiaan VersteegAdd minimum coverage level/label ~"technical change"
### Short description
Add minimum coverage level
/label ~"technical change"
### Short description
Add minimum coverage level
29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1416Link coverage report button to coverage site2019-11-12T16:49:09+01:00Jelle Besselingjelle@pingiun.comLink coverage report button to coverage siteClicking the coverage button now leads you to the coverage informationClicking the coverage button now leads you to the coverage information29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1411Remove utf-8 coding comment2019-11-06T21:09:27+01:00Luna-Elise SchernthanerRemove utf-8 coding commentCloses #942
### Short description
Remove `# -*- coding: utf-8 -*-` from website/events/admin.pyCloses #942
### Short description
Remove `# -*- coding: utf-8 -*-` from website/events/admin.py29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1412Fix API authentication returns 400 when providing the wrong credentials2019-12-04T19:31:08+01:00Simcha van CollemFix API authentication returns 400 when providing the wrong credentialsCloses #959
#### Previous behaviour
Steps to reproduce:
1. Authenticate at `/api/v1/token-auth`
2. Get a 400
#### New behaviour
Steps to validate that it works:
1. Authenticate at `/api/v1/token-auth`
2. Get a 401Closes #959
#### Previous behaviour
Steps to reproduce:
1. Authenticate at `/api/v1/token-auth`
2. Get a 400
#### New behaviour
Steps to validate that it works:
1. Authenticate at `/api/v1/token-auth`
2. Get a 40129https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1380Add Thalia Pay payment methods to admin and user frontend2019-11-06T20:05:08+01:00Job DoesburgAdd Thalia Pay payment methods to admin and user frontendCloses #930 #933 #934
### Short description
TPAY payments are added to the model, options are added to the admin to select Thalia Pay as payment type (only if user has it enabled) and buttons are added to the frontend for pizzas and...Closes #930 #933 #934
### Short description
TPAY payments are added to the model, options are added to the admin to select Thalia Pay as payment type (only if user has it enabled) and buttons are added to the frontend for pizzas and event registrations.
NOTE: `THALIA_PAY_ENABLED_PAYMENT_METHOD` in `/concrexit/website/thaliawebsite/settings/settings.py` should be set to `True` for the payment method to appear for users.
NOTE: The API still needs changes to make this work on the ThaliApp!
### Steps to use this feature
1. Add a bank account with direct debit mandate to a user
2. Try to register for events. A 'Pay with Thalia Pay' button should appear; On cancellation, the payment will be removed; In the admin view, Thalia Pay can only be selected if people have it available. Otherwise the option will be disabled
3. Try to order pizzas. A 'Pay with Thalia Pay' button should appear; On cancellation, the payment will be removed; In the admin view, Thalia Pay can only be selected if people have it available. Otherwise the option will be disabled29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1407Make newsletter event headers and summary clickable2019-11-06T20:58:30+01:00Jelle Besselingjelle@pingiun.comMake newsletter event headers and summary clickableThis includes the code for !1405, to make more things clickable in the newsletter.
### Short description
Make newsletter event headers and summary clickable
### Steps to use this feature
1. View an event in the newsletter
2. C...This includes the code for !1405, to make more things clickable in the newsletter.
### Short description
Make newsletter event headers and summary clickable
### Steps to use this feature
1. View an event in the newsletter
2. Click on the header to go to the event29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1409Add root logging configuration and improve format2019-11-13T22:00:53+01:00Jelle Besselingjelle@pingiun.comAdd root logging configuration and improve formatPreviously no loggers were enabled that concrexit uses. This means that
all logs by concrexit code were ignored in production. This commit adds
a root logger that will make sure all logs by concrexit and imported
packages are logged t...Previously no loggers were enabled that concrexit uses. This means that
all logs by concrexit code were ignored in production. This commit adds
a root logger that will make sure all logs by concrexit and imported
packages are logged to the log file.
This commit also improves the 'verbose' logging format, which previously
contained unneeded information and less specific information on which
package was doing the logging.
Closes #956 and #957https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1408Automatically set warning about fine in newsletter2019-11-06T20:58:30+01:00Jelle Besselingjelle@pingiun.comAutomatically set warning about fine in newsletter### Short description
Automatically set warning about fine in newsletter
### Steps to use this feature
1. Make a newsletter
2. Add an event
3. Checkbox about fine information is automatically checked/unchecked### Short description
Automatically set warning about fine in newsletter
### Steps to use this feature
1. Make a newsletter
2. Add an event
3. Checkbox about fine information is automatically checked/unchecked29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1403Now really fix mailinglists search2019-11-06T18:42:22+01:00Sébastiaan VersteegNow really fix mailinglists searchCloses #876
#### Previous behaviour
Steps to reproduce:
1. Wrong name in the admin code
#### New behaviour
Steps to validate that it works:
1. Right name in the admin codeCloses #876
#### Previous behaviour
Steps to reproduce:
1. Wrong name in the admin code
#### New behaviour
Steps to validate that it works:
1. Right name in the admin code29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1406Remove redundant "What" from newsletter event box2019-11-06T18:42:58+01:00Jelle Besselingjelle@pingiun.comRemove redundant "What" from newsletter event box### Short description
Remove redundant "What" from newsletter event box
### Motivation
This information is always copied from the event title, which is already displayed above the newsletter piece.### Short description
Remove redundant "What" from newsletter event box
### Motivation
This information is always copied from the event title, which is already displayed above the newsletter piece.29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1404Do not use gmail accounts in fixtures2019-10-31T11:02:41+01:00Joren VranckenDo not use gmail accounts in fixtures### Short description
Do not use gmail accounts in fixtures. We run the `sync_mailinglist` cronjob in the staging environment to test it. G Suite warns about non-existing Gmail users that we have in our staging environment. This will rem...### Short description
Do not use gmail accounts in fixtures. We run the `sync_mailinglist` cronjob in the staging environment to test it. G Suite warns about non-existing Gmail users that we have in our staging environment. This will remove those warnings.29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1402Fix small issues in the mailinglists app2019-10-30T23:25:52+01:00Sébastiaan VersteegFix small issues in the mailinglists app
#### Previous behaviour
Steps to reproduce:
1. You could not search for mailinglists
2. Moderated was not clear in the overview
2. The mailinglist sync contained duplicate and empty email addresses
4. List names could be longe...
#### Previous behaviour
Steps to reproduce:
1. You could not search for mailinglists
2. Moderated was not clear in the overview
2. The mailinglist sync contained duplicate and empty email addresses
4. List names could be longer than the maximum
5. No dashes in mailinglist names
#### New behaviour
Steps to validate that it works:
1. You can search for mailinglists again
2. Moderated is now in the overview
2. The mailinglist sync filters out empty and duplicate addresses
4. Maximum of length 60 applied to names
5. Allow dashes in mailinglist names
https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1401Remove threading completely from sync_mailinglists2019-10-30T20:48:03+01:00Sébastiaan VersteegRemove threading completely from sync_mailinglists
#### Previous behaviour
Steps to reproduce:
1. malloc errors
#### New behaviour
Steps to validate that it works:
1. no malloc errors
#### Previous behaviour
Steps to reproduce:
1. malloc errors
#### New behaviour
Steps to validate that it works:
1. no malloc errors28https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1397Remove mailinglists API2019-10-30T20:05:24+01:00Sébastiaan VersteegRemove mailinglists API### Short description
Remove mailinglists API### Short description
Remove mailinglists API28https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1400Send the newsletter to individual members2019-10-30T19:58:04+01:00Sébastiaan VersteegSend the newsletter to individual membersRelated to #947
#### Previous behaviour
Steps to reproduce:
1. Send the newsletter
2. Everyone in the BCC
#### New behaviour
Steps to validate that it works:
1. Send the newsletter
2. Individual emailsRelated to #947
#### Previous behaviour
Steps to reproduce:
1. Send the newsletter
2. Everyone in the BCC
#### New behaviour
Steps to validate that it works:
1. Send the newsletter
2. Individual emailshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1398Fix valid property output to always be an boolean2019-10-30T19:47:07+01:00Sébastiaan VersteegFix valid property output to always be an boolean### Short description
Fix valid property output to always be an boolean. It could be none if valid_from was None### Short description
Fix valid property output to always be an boolean. It could be none if valid_from was None