concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-10-24T19:16:46+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1373Show registration allowed in events api2019-10-24T19:16:46+02:00Gijs HendriksenShow registration allowed in events apiNeeded for ThaliApp#90.
### Short description
Adds the `registration_allowed` field to the events API.
Also makes sure that the `registration_allowed` field in the Events model and the `registered` field in the `EventListSerializer` c...Needed for ThaliApp#90.
### Short description
Adds the `registration_allowed` field to the events API.
Also makes sure that the `registration_allowed` field in the Events model and the `registered` field in the `EventListSerializer` can no longer be `None`.
### Steps to use this feature
1. Visit `/api/v1/events/`.
2. Notice each event has a boolean field `registration_allowed` that indicates whether registrations for this event are open.
3. Notice that the field `registered` is `true` or `false` only, and no longer `null`.29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1372Add missing __init__.py files2019-10-09T19:46:31+02:00Sébastiaan VersteegAdd missing __init__.py files#### Previous behaviour
Steps to reproduce:
1. Start a wsgi server
2. No working
#### New behaviour
Steps to validate that it works:
1. Start a wsgi server
2. Working#### Previous behaviour
Steps to reproduce:
1. Start a wsgi server
2. No working
#### New behaviour
Steps to validate that it works:
1. Start a wsgi server
2. Workinghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1371Add search functionality to the events API2019-11-06T21:35:44+01:00Gijs HendriksenAdd search functionality to the events APINeeded for ThaliApp#92.
### Short description
Adds the ability to search for events in the events API.
### Steps to use this feature
1. Go to `/api/v1/events/?search=[query]`.
2. Notice the events list is filtered on the query terms, ...Needed for ThaliApp#92.
### Short description
Adds the ability to search for events in the events API.
### Steps to use this feature
1. Go to `/api/v1/events/?search=[query]`.
2. Notice the events list is filtered on the query terms, and past events are shown, too.27Wouter DoelandWouter Doelandhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1370Localize committee picture placeholders2019-10-03T16:37:03+02:00Job DoesburgLocalize committee picture placeholdersCloses #914Closes #91427https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1369Fix dataminimisation to no longer remove website2019-10-03T17:09:09+02:00Luna-Elise SchernthanerFix dataminimisation to no longer remove website/label ~bug
Closes #850
#### Previous behaviour
Steps to reproduce:
1. Execute dataminimisation
2. User websites are removed from profiles
#### New behaviour
Steps to validate that it works:
1. Execute dataminimisation.../label ~bug
Closes #850
#### Previous behaviour
Steps to reproduce:
1. Execute dataminimisation
2. User websites are removed from profiles
#### New behaviour
Steps to validate that it works:
1. Execute dataminimisation
2. User websites are not removed from profiles
27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1368Add birthday as readonly field to edit profile page2019-10-03T17:08:49+02:00Job DoesburgAdd birthday as readonly field to edit profile page/label ~bug
Closes #927
#### Previous behaviour
Steps to reproduce:
1. Open the profile edit view
2. I have no idea what my birthday is in the database
3. I can hide/show my birthday but don't know it exists
#### New behav.../label ~bug
Closes #927
#### Previous behaviour
Steps to reproduce:
1. Open the profile edit view
2. I have no idea what my birthday is in the database
3. I can hide/show my birthday but don't know it exists
#### New behaviour
Steps to validate that it works:
1. Open the profile edit view
2. I can see my birthday in the database
3. I can hide/show my birthday and I know it exists
27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1367Fixed data not being properly sent to the calendar2019-10-03T17:05:41+02:00Simcha van CollemFixed data not being properly sent to the calendar/label ~bug
Closes #928
#### Previous behaviour
Steps to reproduce:
1. Open the calendar
2. Notice the birthdays button is always availabe and the unpublished events are never shown.
#### New behaviour
Steps to validate th.../label ~bug
Closes #928
#### Previous behaviour
Steps to reproduce:
1. Open the calendar
2. Notice the birthdays button is always availabe and the unpublished events are never shown.
#### New behaviour
Steps to validate that it works:
1. Open the calendar
2. Notice the birthdays button is not availabe in non-authenticated mode and the unpublished events are shown if you have the permission.
27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1366Resolve "Mailing lists api fails without boards"2019-10-03T17:23:44+02:00Wouter DoelandResolve "Mailing lists api fails without boards"Closes #842
#### Previous behaviour
Steps to reproduce:
1. Start a local server with no boards (thalia.nu has the same problem, but it already has boards so it can't be reproduced there).
2. Go to <ip>/api/v1/mailinglists/
##...Closes #842
#### Previous behaviour
Steps to reproduce:
1. Start a local server with no boards (thalia.nu has the same problem, but it already has boards so it can't be reproduced there).
2. Go to <ip>/api/v1/mailinglists/
#### New behaviour
Steps to validate that it works: (Same as above)
1. Start a local server with no boards (thalia.nu has the same problem, but it already has boards so it can't be reproduced there).
2. Go to <ip>/api/v1/mailinglists/27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1365Update dependency Pillow to ~6.22019-10-03T17:06:45+02:00Thalia TechnicieUpdate dependency Pillow to ~6.2This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Pillow](http://python-pillow.org) ([source](https://github.com/python-pillow/Pillow)) | dependencies | minor | `~6.1` -> `~6.2` |
---
##...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [Pillow](http://python-pillow.org) ([source](https://github.com/python-pillow/Pillow)) | dependencies | minor | `~6.1` -> `~6.2` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- renovate-rebase -->If you want to rebase/retry this MR, check this box
---
Available now for GitLab: [Renovate Pro](https://renovatebot.com/pro) with real-time webhook handling and priority job queue.27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1363Prevent thumbnailing crashes when original is missing2019-10-05T16:49:24+02:00Sébastiaan VersteegPrevent thumbnailing crashes when original is missingCloses #912
#### Previous behaviour
Steps to reproduce:
1. Remove an original image
2. Reload the page where the image should show
3. Crash
#### New behaviour
Steps to validate that it works:
1. Remove an original image
2. Reload the...Closes #912
#### Previous behaviour
Steps to reproduce:
1. Remove an original image
2. Reload the page where the image should show
3. Crash
#### New behaviour
Steps to validate that it works:
1. Remove an original image
2. Reload the page where the image should show
3. No crash27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1362Revisit url schemes2019-10-09T19:02:38+02:00Sébastiaan VersteegRevisit url schemes
Closes #867
### Short description
All urls are now defined in the apps. And we use `path` or `re_path` everywhere.
Closes #867
### Short description
All urls are now defined in the apps. And we use `path` or `re_path` everywhere.27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1361Resolve "Add descriptions to mailing lists"2019-10-03T17:07:18+02:00Luna-Elise SchernthanerResolve "Add descriptions to mailing lists"/label ~feature
Closes #911
### Short description
Adds descriptions to mailing lists
### Steps to use this feature
1. Create or edit a mailing list
2. Notice that you have to add a description
/label ~feature
Closes #911
### Short description
Adds descriptions to mailing lists
### Steps to use this feature
1. Create or edit a mailing list
2. Notice that you have to add a description
27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1360Cannot fill in field for guest registration2019-12-02T22:39:00+01:00Luko van der MaasCannot fill in field for guest registration~bug
Closes #925
#### Previous behaviour
Steps to reproduce:
1. create an event with registration fields
2. add a registration with a name
3. try to change the field
4. nothings happens
#### New behaviour
Steps to valid...~bug
Closes #925
#### Previous behaviour
Steps to reproduce:
1. create an event with registration fields
2. add a registration with a name
3. try to change the field
4. nothings happens
#### New behaviour
Steps to validate that it works:
1. create an event with registration fields
2. add a registration with a name
3. try to change the field
4. it is changed
29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1359Update dependency pylint to ~2.42019-10-03T17:06:45+02:00Thalia TechnicieUpdate dependency pylint to ~2.4This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [pylint](https://github.com/PyCQA/pylint) | dev-dependencies | minor | `~2.3` -> `~2.4` |
---
### Renovate configuration
:date: **Schedu...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [pylint](https://github.com/PyCQA/pylint) | dev-dependencies | minor | `~2.3` -> `~2.4` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- renovate-rebase -->If you want to rebase/retry this MR, check this box
---
Available now for GitLab: [Renovate Pro](https://renovatebot.com/pro) with real-time webhook handling and priority job queue.27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1358Change behaviour of starting year field in registrations2019-10-08T13:54:44+02:00Sébastiaan VersteegChange behaviour of starting year field in registrations#### Previous behaviour
Steps to reproduce:
1. Start a new member registration
2. The field currently contains the next lecture year
3. People make mistakes and select that one instead of the current lecture year
#### New behavi...#### Previous behaviour
Steps to reproduce:
1. Start a new member registration
2. The field currently contains the next lecture year
3. People make mistakes and select that one instead of the current lecture year
#### New behaviour
Steps to validate that it works:
1. Start a new member registration
2. The field currently contains the next lecture year
3. People make mistakes and select that one instead of the current lecture year27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1357Update dependency sentry-sdk to ~0.12.02019-10-03T17:06:45+02:00Thalia TechnicieUpdate dependency sentry-sdk to ~0.12.0This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sentry-sdk](https://github.com/getsentry/sentry-python) | dependencies | minor | `~0.11.0` -> `~0.12.0` |
---
### Renovate configuration...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [sentry-sdk](https://github.com/getsentry/sentry-python) | dependencies | minor | `~0.11.0` -> `~0.12.0` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- renovate-rebase -->If you want to rebase/retry this MR, check this box
---
Available now for GitLab: [Renovate Pro](https://renovatebot.com/pro) with real-time webhook handling and priority job queue.27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1356Change graph types on statistics page2019-10-30T19:45:24+01:00Sébastiaan VersteegChange graph types on statistics pageWork on #58
### Short description
Change graph types on statistics page
Work on #58
### Short description
Change graph types on statistics page
29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1355Improve README on macOS dependencies2019-09-11T22:09:22+02:00Job DoesburgImprove README on macOS dependencies### Short description
README improved by adding message about libmagic dependency on macOS that needs to be installed separately using brew.### Short description
README improved by adding message about libmagic dependency on macOS that needs to be installed separately using brew.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1354Add message to README about version of poetry to use2019-09-15T22:01:31+02:00Job DoesburgAdd message to README about version of poetry to use### Short description
README improved by specifying poetry version to use.### Short description
README improved by specifying poetry version to use.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1353Allow empty values in event registrations API2019-09-15T22:01:43+02:00Gijs HendriksenAllow empty values in event registrations API#### Previous behaviour
The registration API does not allow empty values for text/integer fields that are not required.
Steps to reproduce:
1. Create an event with a registration field that is not required.
2. Register for the event.
3...#### Previous behaviour
The registration API does not allow empty values for text/integer fields that are not required.
Steps to reproduce:
1. Create an event with a registration field that is not required.
2. Register for the event.
3. Use the API to update your event, and leave the registration field empty.
4. The API does not allow it.
#### New behaviour
Steps to validate that it works:
1. Create an event with a registration field that is not required.
2. Register for the event.
3. Use the API to update your event, and leave the registration field empty.
4. The API allows it and your registration is successfully saved.27