concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-09-15T22:01:31+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1354Add message to README about version of poetry to use2019-09-15T22:01:31+02:00Job DoesburgAdd message to README about version of poetry to use### Short description
README improved by specifying poetry version to use.### Short description
README improved by specifying poetry version to use.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1355Improve README on macOS dependencies2019-09-11T22:09:22+02:00Job DoesburgImprove README on macOS dependencies### Short description
README improved by adding message about libmagic dependency on macOS that needs to be installed separately using brew.### Short description
README improved by adding message about libmagic dependency on macOS that needs to be installed separately using brew.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1349Remove FontAwesome as .form-control font-family2019-09-08T14:49:39+02:00Sébastiaan VersteegRemove FontAwesome as .form-control font-familyCloses #918
#### Previous behaviour
Steps to reproduce:
1. Rendering of font incorrect (see issue)
#### New behaviour
Steps to validate that it works:
1. Rendering of font fixed (see issue)Closes #918
#### Previous behaviour
Steps to reproduce:
1. Rendering of font incorrect (see issue)
#### New behaviour
Steps to validate that it works:
1. Rendering of font fixed (see issue)27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1348removed check for expiration date of vacancies2019-09-06T16:55:58+02:00Luko van der Maasremoved check for expiration date of vacanciesCloses #917
#### Previous behaviour
Steps to reproduce:
1. open vacancies page
#### New behaviour
Steps to validate that it works:
1. open vacancies pageCloses #917
#### Previous behaviour
Steps to reproduce:
1. open vacancies page
#### New behaviour
Steps to validate that it works:
1. open vacancies pagehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1346Fix benefactor registrations not receiving email confirmation2019-09-06T16:45:50+02:00Sébastiaan VersteegFix benefactor registrations not receiving email confirmation#### Previous behaviour
Steps to reproduce:
1. Register as benefactor
2. Get no email confirmation message
#### New behaviour
Steps to validate that it works:
1. Register as benefactor
2. Get an email confirmation message#### Previous behaviour
Steps to reproduce:
1. Register as benefactor
2. Get no email confirmation message
#### New behaviour
Steps to validate that it works:
1. Register as benefactor
2. Get an email confirmation messagehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1345Fix permission in admin views of pizzas2019-09-04T21:05:53+02:00Sébastiaan VersteegFix permission in admin views of pizzas#### Previous behaviour
Steps to reproduce:
1. Try to change orders of pizzas
#### New behaviour
Steps to validate that it works:
1. Try to change orders of pizzas#### Previous behaviour
Steps to reproduce:
1. Try to change orders of pizzas
#### New behaviour
Steps to validate that it works:
1. Try to change orders of pizzas26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1344Fix thumbnailer collision2019-09-04T19:30:08+02:00Thom WiggersFix thumbnailer collisionWe now handle the uploading of files based on the Storage api, and make sure to use its methods to prevent collisions.
In addition, it now drops user-provided filenames completely, and instead generates them randomly.
#### Previous beh...We now handle the uploading of files based on the Storage api, and make sure to use its methods to prevent collisions.
In addition, it now drops user-provided filenames completely, and instead generates them randomly.
#### Previous behaviour
Steps to reproduce:
1. Withheld26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1337Photos show rotated2019-09-04T19:19:28+02:00Luko van der MaasPhotos show rotatedCloses #904
View photo with rotation, these will now be rotated correctlyCloses #904
View photo with rotation, these will now be rotated correctly26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1343Don't generate invalid membership dates2019-09-04T19:07:57+02:00Thom WiggersDon't generate invalid membership dates#### Previous behaviour
Steps to reproduce:
1. Generate fixtures
2. Try to change one that has a membership expiration date < membership start date
3. observe validation rejects you
#### New behaviour
Steps to validate that it works:
...#### Previous behaviour
Steps to reproduce:
1. Generate fixtures
2. Try to change one that has a membership expiration date < membership start date
3. observe validation rejects you
#### New behaviour
Steps to validate that it works:
1. See that no longer happens.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1342Always quote nicknames.2019-09-04T13:18:24+02:00Thom WiggersAlways quote nicknames.Always quote nicknames.
Otherwise it's possible to set your nickname to 'Jen Dusseljee' and from the front end you can't tell that it's a nicknameAlways quote nicknames.
Otherwise it's possible to set your nickname to 'Jen Dusseljee' and from the front end you can't tell that it's a nickname26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1339Correct translations of 'wire payment'2019-09-03T12:29:47+02:00Sébastiaan VersteegCorrect translations of 'wire payment'#### Previous behaviour
Steps to reproduce:
1. Dutch translation in payments app of wire transfer payments was 'Pin betaling'
#### New behaviour
Steps to validate that it works:
1. Dutch translation in payments app of wire transfer pa...#### Previous behaviour
Steps to reproduce:
1. Dutch translation in payments app of wire transfer payments was 'Pin betaling'
#### New behaviour
Steps to validate that it works:
1. Dutch translation in payments app of wire transfer payments is now 'Overboeking'26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1336Push notifications don't show content only title twice2019-08-31T12:57:12+02:00Luko van der MaasPush notifications don't show content only title twiceMessage sent from event now has correct body instead of the title
Closes #906Message sent from event now has correct body instead of the title
Closes #90626https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1325Add explicit end date for members to board pages2019-08-28T20:11:23+02:00Sébastiaan VersteegAdd explicit end date for members to board pagesCloses #857
### Short description
Add explicit end date for members to board pages
### Steps to use this feature
1. Add a board membership that ends prematurely
2. Check the date on the board pageCloses #857
### Short description
Add explicit end date for members to board pages
### Steps to use this feature
1. Add a board membership that ends prematurely
2. Check the date on the board page26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1323Wire transfer payments for events2019-08-28T20:10:35+02:00Sébastiaan VersteegWire transfer payments for eventsCloses #838
### Short description
Wire transfer payments for events
### Steps to use this feature
1. Go to the events admin and use the selectbox to edit paymentsCloses #838
### Short description
Wire transfer payments for events
### Steps to use this feature
1. Go to the events admin and use the selectbox to edit payments26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1335Update dependency firebase-admin to ~2.182019-08-28T20:01:56+02:00Thalia TechnicieUpdate dependency firebase-admin to ~2.18This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [firebase-admin](https://firebase.google.com/docs/admin/setup/) ([changelog](https://firebase.google.com/support/release-notes/admin/python...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [firebase-admin](https://firebase.google.com/docs/admin/setup/) ([changelog](https://firebase.google.com/support/release-notes/admin/python)) | dependencies | minor | `~2.17` -> `~2.18` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- renovate-rebase -->If you want to rebase/retry this MR, check this box
---
Available now for GitLab: [Renovate Pro](https://renovatebot.com/pro) with real-time webhook handling and priority job queue.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1320Improve event categories2019-09-04T19:37:35+02:00Sébastiaan VersteegImprove event categoriesCloses #869
### Short description
Improve event categoriesCloses #869
### Short description
Improve event categories26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1331Adjust CSS for accordion elements2019-08-28T19:58:43+02:00Sébastiaan VersteegAdjust CSS for accordion elementsAdds a missing bottom border.
#### Previous behaviour
![Screenshot_2019-08-16_at_12.32.27](/uploads/6c400ac64c9f4f25791c885ff5ffe831/Screenshot_2019-08-16_at_12.32.27.png)
#### New behaviour
![Screenshot_2019-08-16_at_12.32.16](/...Adds a missing bottom border.
#### Previous behaviour
![Screenshot_2019-08-16_at_12.32.27](/uploads/6c400ac64c9f4f25791c885ff5ffe831/Screenshot_2019-08-16_at_12.32.27.png)
#### New behaviour
![Screenshot_2019-08-16_at_12.32.16](/uploads/fdca28be337dd606ffd036fe85b75b59/Screenshot_2019-08-16_at_12.32.16.png)26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1330Block benefactors or non-members in the next lecture year from giving references2019-08-31T13:02:26+02:00Sébastiaan VersteegBlock benefactors or non-members in the next lecture year from giving referencesCloses #901 #902 #903
#### Previous behaviour
Steps to reproduce:
1. See the issues
#### New behaviour
Steps to validate that it works:
1. See the issuesCloses #901 #902 #903
#### Previous behaviour
Steps to reproduce:
1. See the issues
#### New behaviour
Steps to validate that it works:
1. See the issues26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1334Prevent unpublished events from ending up in the newsletter2019-08-28T19:20:57+02:00Sébastiaan VersteegPrevent unpublished events from ending up in the newsletterCloses #905
#### Previous behaviour
Steps to reproduce:
When you create a newsletter and there are unpublished events in the next two weeks they are included in the newsletter.
#### New behaviour
Steps to validate that it works:
Unp...Closes #905
#### Previous behaviour
Steps to reproduce:
When you create a newsletter and there are unpublished events in the next two weeks they are included in the newsletter.
#### New behaviour
Steps to validate that it works:
Unpublished events are not be included.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1322Remove obsolete Topicus logo HTML from newsletter2019-08-28T19:18:46+02:00Sébastiaan VersteegRemove obsolete Topicus logo HTML from newsletter### Short description
Remove obsolete Topicus logo HTML from newsletter### Short description
Remove obsolete Topicus logo HTML from newsletter26