From 97ba3353d581bb6e125e4cdb541a09b8d7dfa687 Mon Sep 17 00:00:00 2001 From: Tobias van der Werff Date: Wed, 6 Feb 2019 21:33:25 +0100 Subject: [PATCH] Add 'Display members' field for MemberGroup --- website/activemembers/admin.py | 9 +++-- .../0037_membergroup_display_members.py | 18 ++++++++++ website/activemembers/models.py | 4 +++ .../activemembers/membergroup_detail.html | 36 ++++++++++--------- 4 files changed, 47 insertions(+), 20 deletions(-) create mode 100644 website/activemembers/migrations/0037_membergroup_display_members.py diff --git a/website/activemembers/admin.py b/website/activemembers/admin.py index 0b347e50..74e3e924 100644 --- a/website/activemembers/admin.py +++ b/website/activemembers/admin.py @@ -51,7 +51,8 @@ class CommitteeAdmin(TranslatedModelAdmin): filter_horizontal = ('permissions',) fields = ('name', 'description', 'photo', 'permissions', 'since', - 'until', 'contact_mailinglist', 'contact_email', 'active') + 'until', 'contact_mailinglist', 'contact_email', 'active', + 'display_members') def email(self, instance): if instance.contact_email: @@ -72,7 +73,8 @@ class SocietyAdmin(TranslatedModelAdmin): filter_horizontal = ('permissions',) fields = ('name', 'description', 'photo', 'permissions', 'since', - 'until', 'contact_mailinglist', 'contact_email', 'active') + 'until', 'contact_mailinglist', 'contact_email', 'active', + 'display_members') def email(self, instance): if instance.contact_email: @@ -91,7 +93,8 @@ class BoardAdmin(TranslatedModelAdmin): filter_horizontal = ('permissions',) fields = ('name', 'description', 'photo', 'permissions', - 'contact_mailinglist', 'contact_email', 'since', 'until',) + 'contact_mailinglist', 'contact_email', 'since', 'until', + 'display_members') class TypeFilter(admin.SimpleListFilter): diff --git a/website/activemembers/migrations/0037_membergroup_display_members.py b/website/activemembers/migrations/0037_membergroup_display_members.py new file mode 100644 index 00000000..5f6186bc --- /dev/null +++ b/website/activemembers/migrations/0037_membergroup_display_members.py @@ -0,0 +1,18 @@ +# Generated by Django 2.1.5 on 2019-02-06 19:14 + +from django.db import migrations, models + + +class Migration(migrations.Migration): + + dependencies = [ + ('activemembers', '0036_auto_20181024_1939'), + ] + + operations = [ + migrations.AddField( + model_name='membergroup', + name='display_members', + field=models.BooleanField(default=False), + ), + ] diff --git a/website/activemembers/models.py b/website/activemembers/models.py index e3e764d2..78b545af 100644 --- a/website/activemembers/models.py +++ b/website/activemembers/models.py @@ -95,6 +95,10 @@ class MemberGroup(models.Model, metaclass=ModelTranslateMeta): on_delete=models.SET_NULL, ) + display_members = models.BooleanField( + default=False, + ) + @property def contact_address(self): if self.contact_mailinglist: diff --git a/website/activemembers/templates/activemembers/membergroup_detail.html b/website/activemembers/templates/activemembers/membergroup_detail.html index 02ec142e..bce911a6 100644 --- a/website/activemembers/templates/activemembers/membergroup_detail.html +++ b/website/activemembers/templates/activemembers/membergroup_detail.html @@ -34,22 +34,24 @@ {% endif %} -
-
-

- {% trans 'Members' %} -

+ {% if membergroup.display_members %} +
+
+

+ {% trans 'Members' %} +

-
- {% for member in members %} -
- {% membergroup_member_card member %} -
- {% empty %} - {% trans "This group doesn't have any members?" as empty %} - {% alert 'danger' empty extra_classes='col-10 offset-1' %} - {% endfor %} -
-
-
+
+ {% for member in members %} +
+ {% membergroup_member_card member %} +
+ {% empty %} + {% trans "This group doesn't have any members?" as empty %} + {% alert 'danger' empty extra_classes='col-10 offset-1' %} + {% endfor %} +
+
+
+ {% endif %} {% endblock %} -- GitLab