From bb2ead56443f8adaf77d127bd7f272e794e5b131 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastiaan=20Versteeg?= Date: Wed, 14 Aug 2019 17:14:15 +0200 Subject: [PATCH 1/2] Add test values for no_references post value --- website/registrations/tests/test_views.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/website/registrations/tests/test_views.py b/website/registrations/tests/test_views.py index e0b29c83..ce703825 100644 --- a/website/registrations/tests/test_views.py +++ b/website/registrations/tests/test_views.py @@ -672,6 +672,7 @@ class RenewalFormViewTest(TestCase): request = super_post.call_args[0][0] self.assertEqual(request.POST['member'], 2) self.assertEqual(request.POST['remarks'], '') + self.assertEqual(request.POST['no_references'], True) with self.subTest('Forced benefactor type'): request = self.rf.post('/', { @@ -689,6 +690,7 @@ class RenewalFormViewTest(TestCase): self.assertEqual(request.POST['membership_type'], Membership.BENEFACTOR) self.assertEqual(request.POST['length'], Entry.MEMBERSHIP_YEAR) + self.assertEqual(request.POST['no_references'], False) with self.subTest('Detects old memberships'): request = self.rf.post('/', { @@ -703,6 +705,7 @@ class RenewalFormViewTest(TestCase): request = super_post.call_args[0][0] self.assertEqual(request.POST['remarks'], 'Was a Thalia member in the past.') + self.assertEqual(request.POST['no_references'], True) with self.subTest('Adds iCIS remark'): request = self.rf.post('/', { @@ -718,6 +721,7 @@ class RenewalFormViewTest(TestCase): request = super_post.call_args[0][0] self.assertEqual(request.POST['remarks'], 'Registered as iCIS employee.') + self.assertEqual(request.POST['no_references'], True) @mock.patch('registrations.emails.send_references_information_message') @mock.patch('registrations.emails.send_new_renewal_board_message') -- GitLab From 5aeed7c3f8c0123fe3fc902673293ac9fcee3f13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastiaan=20Versteeg?= Date: Wed, 14 Aug 2019 17:15:17 +0200 Subject: [PATCH 2/2] Fix no_references post value --- website/registrations/views.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/website/registrations/views.py b/website/registrations/views.py index 7f0fee01..79a48bea 100644 --- a/website/registrations/views.py +++ b/website/registrations/views.py @@ -228,9 +228,10 @@ class RenewalFormView(FormView): request.POST['length'] = Entry.MEMBERSHIP_YEAR request.POST['member'] = request.member.pk request.POST['remarks'] = '' - request.POST['no_references'] = False + request.POST['no_references'] = True if request.POST['membership_type'] == Membership.BENEFACTOR: + request.POST['no_references'] = False if Membership.objects.filter(user=request.member, type=Membership.MEMBER).exists(): request.POST['remarks'] = 'Was a Thalia member in the past.' -- GitLab