concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-10-19T09:21:52+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/940AttributeError: module 'firebase_admin.messaging' has no attribute 'ApiCallEr...2019-10-19T09:21:52+02:00Thalia TechnicieAttributeError: module 'firebase_admin.messaging' has no attribute 'ApiCallError'Sentry Issue: [CONCREXIT-12](https://sentry.io/organizations/thalia/issues/1279980295/?referrer=gitlab_integration)
```
HTTPError: 401 Client Error: Unauthorized for url: https://fcm.googleapis.com/v1/projects/thalia-493a0/messages:send...Sentry Issue: [CONCREXIT-12](https://sentry.io/organizations/thalia/issues/1279980295/?referrer=gitlab_integration)
```
HTTPError: 401 Client Error: Unauthorized for url: https://fcm.googleapis.com/v1/projects/thalia-493a0/messages:send
File "firebase_admin/messaging.py", line 349, in send
timeout=self._timeout
File "firebase_admin/_http_client.py", line 117, in body
resp = self.request(method, url, **kwargs)
File "firebase_admin/_http_client.py", line 105, in request
resp.raise_for_status()
File "requests/models.py", line 940, in raise_for_status
raise HTTPError(http_error_msg, response=self)
ThirdPartyAuthError: Auth error from APNS or Web Push Service
File "pushnotifications/models.py", line 175, in send
'dry_run', False))
File "firebase_admin/messaging.py", line 114, in send
return _get_messaging_service(app).send(message, dry_run)
File "firebase_admin/messaging.py", line 352, in send
raise self._handle_fcm_error(error)
AttributeError: module 'firebase_admin.messaging' has no attribute 'ApiCallError'
(2 additional frame(s) were not displayed)
...
File "django/core/management/__init__.py", line 375, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "django/core/management/base.py", line 323, in run_from_argv
self.execute(*args, **cmd_options)
File "django/core/management/base.py", line 364, in execute
output = self.handle(*args, **options)
File "pushnotifications/management/commands/send_scheduled_messages.py", line 44, in handle
message.send(dry_run=bool(options['dry-run']))
File "pushnotifications/models.py", line 177, in send
except messaging.ApiCallError as e:
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/766Remove usage of Celery for push notifications2018-11-28T18:52:23+01:00Sébastiaan VersteegRemove usage of Celery for push notifications### One-sentence description
Remove usage of Celery for push notifications
### Why?
Celery is not performing as expected.
### Current implementation
Celery is used to schedule push notifications
### Suggested implementation
Use a ...### One-sentence description
Remove usage of Celery for push notifications
### Why?
Celery is not performing as expected.
### Current implementation
Celery is used to schedule push notifications
### Suggested implementation
Use a management command and cronjob instead20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/655Do not schedule/revoke messages for unpublished events2018-07-09T09:39:38+02:00Sébastiaan VersteegDo not schedule/revoke messages for unpublished events### One-sentence description
Do not schedule/revoke messages for unpublished events
### Current behaviour
Non published events still schedule messages
### Expected behaviour
No messages should be schedule
### Steps to reproduce
1....### One-sentence description
Do not schedule/revoke messages for unpublished events
### Current behaviour
Non published events still schedule messages
### Expected behaviour
No messages should be schedule
### Steps to reproduce
1. Create an event1.17https://gitlab.science.ru.nl/thalia/concrexit/-/issues/894Typo in notification type description2019-06-27T13:47:35+02:00Job DoesburgTypo in notification type description### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<...### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/875Use Firebase SDK batch sending2019-08-04T18:46:25+02:00Sébastiaan VersteegUse Firebase SDK batch sending<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
Because it wasn't possible before: https://firebase.google.com/support/release-notes/admin/python#version_2170_-_may_23_2019
### Current implementation
No batch sending: https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/pushnotifications/models.py#L172
### Suggested implementation
Batch sending using the new API.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/777Automatic notification after uploading a new photo album2019-05-09T13:08:23+02:00Sébastiaan VersteegAutomatic notification after uploading a new photo album### One-sentence description
Automatic notification after uploading a new photo album
### Motivation
So that people are up-to-date and know when new photos are available.
### Desired functionality
Send a notification to all members ...### One-sentence description
Automatic notification after uploading a new photo album
### Motivation
So that people are up-to-date and know when new photos are available.
### Desired functionality
Send a notification to all members roughly one hour after make the photos available (= uploading+not hidden).24Tobias van der WerffTobias van der Werffhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/776Automatic notification before end of pizza ordering2019-01-17T13:09:05+01:00Sébastiaan VersteegAutomatic notification before end of pizza ordering### One-sentence description
Automatic notification before end of pizza ordering
### Motivation
Because it's cool and useful!
### Desired functionality
Get a notification for every pizza event at the moment there are 10 minutes left ...### One-sentence description
Automatic notification before end of pizza ordering
### Motivation
Because it's cool and useful!
### Desired functionality
Get a notification for every pizza event at the moment there are 10 minutes left to order your pizzas. If the pizza event is attached to an event with registrations only registered members will get the notification, instead of everyone.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/707Add descriptions to push notification categories2018-09-19T20:17:56+02:00Gijs HendriksenAdd descriptions to push notification categories### One-sentence description
Add descriptions to notification categories
### Desired behaviour
As described in ThaliApp#75, the ThaliApp settings screen can now only display the push notifications category names. However, some of these ...### One-sentence description
Add descriptions to notification categories
### Desired behaviour
As described in ThaliApp#75, the ThaliApp settings screen can now only display the push notifications category names. However, some of these names don't make it clear what kind of push notifications are sent through in this category. Thus, it would be useful to add an explanation of each of the categories.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/636Add deeplinking functionality to push notifications2018-09-19T19:11:02+02:00Sébastiaan VersteegAdd deeplinking functionality to push notifications### One-sentence description
Add deeplinking functionality to push notifications
### Desired behaviour
We should have a way of adding a payload to notifications so that the app can open the right screen when they're pressed.### One-sentence description
Add deeplinking functionality to push notifications
### Desired behaviour
We should have a way of adding a payload to notifications so that the app can open the right screen when they're pressed.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/583Improve documentation for the pushnotifications module2018-09-12T16:22:39+02:00Thom WiggersImprove documentation for the pushnotifications moduleThe ~"push notifications" module could use improved docs.The ~"push notifications" module could use improved docs.Improve documentation