concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-03-04T20:22:40+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1025ValueError: day is out of range for month2020-03-04T20:22:40+01:00Thalia TechnicieValueError: day is out of range for monthSentry Issue: [CONCREXIT-24](https://sentry.io/organizations/thalia/issues/1538288408/?referrer=gitlab_integration)
```
ValueError: day is out of range for month
(11 additional frame(s) were not displayed)
...
File "rest_framework/ser...Sentry Issue: [CONCREXIT-24](https://sentry.io/organizations/thalia/issues/1538288408/?referrer=gitlab_integration)
```
ValueError: day is out of range for month
(11 additional frame(s) were not displayed)
...
File "rest_framework/serializers.py", line 260, in data
self._data = self.to_representation(self.instance)
File "rest_framework/serializers.py", line 529, in to_representation
ret[field.field_name] = field.to_representation(attribute)
File "rest_framework/fields.py", line 1905, in to_representation
return method(value)
File "members/api/serializers.py", line 93, in _achievements
return member_achievements(instance.user)
File "members/services.py", line 72, in member_achievements
earliest = earliest.replace(year=earliest.year + mentor_year.year)
```Marie SimonMarie Simonhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1020Do not use hardcoded colors for calendar API2020-03-04T17:06:42+01:00Job DoesburgDo not use hardcoded colors for calendar API<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Do not use hardcoded colors for calendar API in `website/members/api/serializers.py` r42-49 and `website/events/api/serializers.py`
### Why?
We shouldn't hardcode these things at the API level but provide them using CSS.
### Current implementation
The API provides a `backgroundColor` and `textColor` in the event sources APIs that is used by FullCalendar via https://fullcalendar.io/docs/events-json-feed. Every item in the feed is an event source object: https://fullcalendar.io/docs/event-source-object.
### Suggested implementation
Provide a `className` attribute instead and determine the background color and text color based on the class using CSS.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1017Remove redundant html templates from `/thaliawebsite/templates/singlepages/`2020-03-13T16:29:15+01:00Job DoesburgRemove redundant html templates from `/thaliawebsite/templates/singlepages/`<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove redundant html templates from `/thaliawebsite/templates/singlepages/`
### Why?
They are redundant, since they are also in `/singlepages/templates` and these are the ones that are used.
### Current implementation
It appears as if the translations are still in `/thaliawebsite` though, so it would probably be nice to move these.
### Suggested implementationMarthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/971Missing translations in information check email2020-02-19T21:13:59+01:00Jelle Besselingjelle@pingiun.comMissing translations in information check email### One-sentence description
Information check email has some missing translations
### Current behaviour / Reproducing the bug
Send an information check email, notice some weird text missing.
### Expected behaviour
Information check ma...### One-sentence description
Information check email has some missing translations
### Current behaviour / Reproducing the bug
Send an information check email, notice some weird text missing.
### Expected behaviour
Information check mail contains correct translations
<!-- Please write how what happened did not meet your expectations -->Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/778Birthday congratulations push-notification2019-10-02T20:47:38+02:00Job DoesburgBirthday congratulations push-notification<!--
You want something new.
-->
### One-sentence description
An automated push-notification on your phone at your birthday.
### Motivation
Just for fun. For real, give it the lowest priority possible, I only thought of it a minu...<!--
You want something new.
-->
### One-sentence description
An automated push-notification on your phone at your birthday.
### Motivation
Just for fun. For real, give it the lowest priority possible, I only thought of it a minute ago and it would be fun.
### Desired functionality
Thalia has members. Those members are persons. Persons have a date of birth. Thalia knows this date of birth. Often this day is considered a special day that is celebrated. Thalia loves their members. So let’s congratulate our members at their birthday!
### Suggested implementation
Schedule push notifications for members based on their birthday. When to schedule it exactly is up to you, I think you know best (do it after every reboot for the upcoming week, or just every birthday for the next year, I don’t know what’s optimal).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/593Warn the organiser when the maximum number of participants of an event is cha...2020-01-29T18:43:19+01:00Lennart JansenWarn the organiser when the maximum number of participants of an event is changed### One-sentence description
https://gitlab.science.ru.nl/thalia/
### Current behaviour
People on the waiting list don't get any notification and thus cannot know that their status changed.
### Expected behaviour
The organiser shoul...### One-sentence description
https://gitlab.science.ru.nl/thalia/
### Current behaviour
People on the waiting list don't get any notification and thus cannot know that their status changed.
### Expected behaviour
The organiser should do a follow-up.
### Steps to reproduce
1. Create an event
2. Enable x registrations
3. Register at least x+1 people
4. Change the number of registrations to x+1
5. See that the person x+1 didn't get an email notificationMario TsatsevMario Tsatsevhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/58Improve statistics2020-02-19T21:11:58+01:00Thom WiggersImprove statistics### One-sentence description
Improve statistics
### Changed behaviour
After merging !46 (ref #9), we could improve the statistics page.
Suggestions:
- Add statistics about event attendance sorted by event type (from #389)
- Pizza char...### One-sentence description
Improve statistics
### Changed behaviour
After merging !46 (ref #9), we could improve the statistics page.
Suggestions:
- Add statistics about event attendance sorted by event type (from #389)
- Pizza chart. Showing percentages of everything > 5% with a max of 10 and everything else is 'other'
- Top 10 memberships of committees
- Percentage of active members compared to non-active members
- Bar chart with number of members per committees.
- Events heatmap with number of events per week
Also, some header on the page are unclear. As mentioned in #366.