Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • C clm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • clean-and-itasksclean-and-itasks
  • clm
  • Merge requests
  • !12

Fix quoting of imported object files in calls to spawn

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Camil Staps requested to merge windows-fixes into master Oct 14, 2020
  • Overview 2
  • Commits 3
  • Pipelines 2
  • Changes 1

This allows me to compile all of Platform in one go (there was no issue with command line length).

Linker errors are sent to stderr by the linker, so they were lost by clm. I added code to redirect them to linkerrs.$$$ (following the naming convention of cgopt.$$$/linker.$$$), and subsequently print the errors and remove the file again. I know that you can do this in memory with a separate thread (as is done with the compiler), but I couldn't get this to work so quickly, we don't need live redirection, and it doesn't really seem worth the extra code to clean up the threads etc. afterwards. So I hope this is OK.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: windows-fixes