Skip to content
Snippets Groups Projects

Quote arguments with mingw

Merged Ghost User requested to merge quote-arguments-with-mingw into master

It turns out that when compiling with MinGW you should also quote arguments to spawn. This also revealed two other problems: one where I inadvertently removed the closing " from the kernel_library etc. arguments; the other where the arguments to the linker are already quoted and do not need to be quoted again when creating the command line for CreateProcess.

Sorry that this all happens in separate MRs, because I first didn't realise the environment on the build server was different, and then wasn't sure how to reproduce it exactly, it was a bit tricky... The platform test runs OK with these changes (https://gitlab.science.ru.nl/clean-and-itasks/clean-platform/-/jobs/109873), so hopefully this is the last change for the time being.

Merge request reports

Pipeline #45991 passed

Pipeline passed for e9c6af2e on quote-arguments-with-mingw

Merged by John van GroningenJohn van Groningen 4 years ago (Oct 16, 2020 8:57am UTC)

Loading

Pipeline #46016 passed

Pipeline passed for 58b02cee on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading