Merge pull request #3630 from nextcloud/techdept/remove-skipped-tests

Remove skipped tests

tests/Integration/Service/AvatarServiceIntegrationTest.php

@@ -58,17 +58,6 @@ class AvatarServiceIntegrationTest extends TestCase {
 		$this->assertNotNull($image);
 	}
 
-	public function testGithubFavicon() {
-		$this->markTestSkipped('does not work reliably at the moment');
-		return;
-
-		$avatar = $this->service->getAvatar('no-reply@github.com', 'jane');
-		$this->assertNotNull($avatar);
-		$this->assertEquals('https://github.githubassets.com/favicon.ico', $avatar->getUrl());
-		$image = $this->service->getAvatarImage('no-reply@github.com', 'jane');
-		$this->assertNotNull($image);
-	}
-
 	public function testChristophsFavicon() {
 		$avatar = $this->service->getAvatar('christoph@winzerhof-wurst.at', 'jan');
 		$this->assertNull($avatar); // There is none

tests/Unit/Controller/MessagesControllerTest.php

@@ -161,21 +161,6 @@ class MessagesControllerTest extends TestCase {
 		\OC::$server->offsetSet(ITimeFactory::class, $this->oldFactory);
 	}
 
-	public function testIndex() {
-		// TODO: write test
-		$this->markTestSkipped('todo');
-	}
-
-	public function testShow() {
-		// TODO: write test
-		$this->markTestSkipped('todo');
-	}
-
-	public function testShowMessageNotFound() {
-		// TODO: write test
-		$this->markTestSkipped('todo');
-	}
-
 	public function testGetHtmlBody() {
 		$accountId = 17;
 		$mailboxId = 13;

tests/Unit/Service/AccountServiceTest.php

@@ -106,11 +106,6 @@ class AccountServiceTest extends TestCase {
 		$this->assertEquals($expected, $actual);
 	}
 
-	public function testFindNotFound() {
-		// TODO: implement code + write tests
-		$this->markTestSkipped('todo');
-	}
-
 	public function testDelete() {
 		$accountId = 33;
 

tests/Unit/Service/Autoconfig/IspDbTest.php

@@ -23,7 +23,6 @@
 namespace OCA\Mail\Tests\Unit\Service\Autoconfig;
 
 use ChristophWurst\Nextcloud\Testing\TestCase;
-use OCA\Mail\Service\AutoConfig\IspDb;
 use OCP\ILogger;
 
 class IspDbtest extends TestCase {
@@ -44,21 +43,6 @@ class IspDbtest extends TestCase {
 		];
 	}
 
-	/**
-	 * @dataProvider queryData
-	 *
-	 * @param string $domain
-	 * @param string $email
-	 */
-	public function testQueryRealServers(string $domain, string $email): void {
-		$this->markTestSkipped('does not work reliably');
-		return;
-
-		$ispDb = new IspDb($this->logger);
-		$result = $ispDb->query($domain, $email);
-		$this->assertContainsIspData($result);
-	}
-
 	public function fakeAutoconfigData() {
 		return [
 			['freenet.de', 'user@freenet.de', true],