Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • ThaliApp ThaliApp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 4
    • Merge requests 4
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • thaliathalia
  • ThaliAppThaliApp
  • Merge requests
  • !200

Fixed loggedInSelector and moved selectors to separate file

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gijs Hendriksen requested to merge fix/android-push-notifications into master Sep 07, 2018
  • Overview 0
  • Commits 1
  • Changes 23

Closes #74

Previous behaviour

loggedInSelector still used the navigation reducer, which no longer exists since we switched to React Navigation. Because of this, the deeplinking saga crashed and caused the app to get stuck at the splash screen.

Steps to reproduce:

  1. Open a deeplink, like https://thalia.nu/events/1/.
  2. Notice the app is stuck on the splash screen.

New behaviour

The loggedInSelector is updated to use the new status field in the session state. In order to avoid a circular import, the selectors have been moved to a new folder, which will also contain any future selectors we add.

Steps to validate that it works:

  1. Open a deeplink, like https://thalia.nu/events/1/.
  2. Notice the app handles it correctly.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/android-push-notifications