Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • ThaliApp ThaliApp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 4
    • Merge requests 4
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • thaliathalia
  • ThaliAppThaliApp
  • Merge requests
  • !215

Fix form validation in event registration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gijs Hendriksen requested to merge fix/event-registration-form-validation into master Nov 15, 2018
  • Overview 0
  • Commits 1
  • Changes 2

Closes #87

Previous behaviour

App crashes when an integer field is emptied.

Steps to reproduce:

  1. Open an event registration with a required integer field.
  2. Delete the value.
  3. Notice the app crashes.

New behaviour

App no longer crashes when an integer field is emptied. Also, it now correctly handles required boolean fields.

Steps to validate that it works:

  1. Open an event registration with a required integer field.
  2. Delete the value.
  3. Notice the app no longer crashes, and instead adds a notice that the integer field is invalid.
Edited Nov 15, 2018 by Gijs Hendriksen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/event-registration-form-validation