Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • ThaliApp ThaliApp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 4
    • Merge requests 4
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • thaliathalia
  • ThaliAppThaliApp
  • Merge requests
  • !384

Update registration field if it is empty

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gijs Hendriksen requested to merge fix/cannot-clear-event-information-fields into master Sep 11, 2019
  • Overview 0
  • Commits 1
  • Changes 1

Closes #101

Depends on concrexit!1353 (merged), as the API does not correctly accept empty field values.

Previous behaviour

If an event registration field is empty, the app does not send it to the website, meaning it is never updated.

Steps to reproduce:

  1. Create an event with a registration field that is not required.
  2. Register for the event and set the registration field.
  3. Update your registration and clear the information field.
  4. Notice the information field still contains the old value.

New behaviour

Steps to validate that it works:

  1. Create an event with a registration field that is not required.
  2. Register for the event and set the registration field.
  3. Update your registration and clear the information field.
  4. Notice the information field is correctly updated.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/cannot-clear-event-information-fields