Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
concrexit
concrexit
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 10
    • Merge Requests 10
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • thalia
  • concrexitconcrexit
  • Issues
  • #1011

Closed
Open
Opened Feb 12, 2020 by Job Doesburg@jdoesburgContributor

Use create_payment everywhere

One-sentence description

Use create_payment (from #1010 (closed) ) everywhere where we use payments

Why?

Prevent code duplication

Current implementation

Shitty, chaotic, anarchy, tears

Suggested implementation

Make models Payable (implement the interface / abstract class from #1010 (closed)) and use create_payment as the only way to interact with / create payments.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: thalia/concrexit#1011