Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • concrexit concrexit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • thaliathalia
  • concrexitconcrexit
  • Merge requests
  • !1072

Payments package additions and changes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sébastiaan Versteeg requested to merge tc/payment-additions into master Nov 25, 2018
  • Overview 0
  • Commits 9
  • Changes 26

Closes no issue

Short description

This MR moves the admin urls of payments to the backend, it adds fields to the Payment model to keep track of who paid for and who processed a payment and the payment widget has the process buttons integrated now (see screenshot), then I added a notes field that can be used to write down what a payment is/was for (if we start removing registrations/renewals for the GDPR this may be worth a lot) and wrote a migration that fills in the paid by/notes fields for the existing payments created for registrations. Last but not least: I moved the processed state into the type field. Basically because those fields could either be both filled or both empty, now the payment is seen as processed when the type field is not equal to no_payment which is now the default value instead of None.

This last change massively improves the UX of the registrations package, since going to the payment, processing and going back is now one action: click the process button.

Screenshot_2018-11-25_at_18.06.37

Edited Nov 27, 2018 by Sébastiaan Versteeg
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tc/payment-additions