Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • concrexit concrexit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • thaliathalia
  • concrexitconcrexit
  • Merge requests
  • !1228

Fix some small bugs in the automatic newsletter event code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sébastiaan Versteeg requested to merge fix/newsletter-event-js into master Apr 14, 2019
  • Overview 0
  • Commits 1
  • Changes 3

Closes #861 (closed)

Previous behaviour

Steps to reproduce:

  1. Create a newsletter event and automatic dropdown
  2. Entered end date does not match the end date of the event

  1. The costs are never shown in the newsletter preview

  1. The automatic event selection always uses the dutch event title in the dropdown

New behaviour

Steps to validate that it works:

  1. Create a newsletter event and automatic dropdown
  2. Entered end date matches the end date of the event

  1. The costs are shown in the newsletter preview when price > 0 and the checkbox is checked

  1. The automatic event selection uses the current language title in the dropdown
Edited Apr 14, 2019 by Sébastiaan Versteeg
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/newsletter-event-js