Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
concrexit
concrexit
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 10
    • Merge Requests 10
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • thalia
  • concrexitconcrexit
  • Merge Requests
  • !1381

Merged
Opened Oct 17, 2019 by Sébastiaan Versteeg@sversteegOwner

Fix removal of Firebase Admin SDK error

  • Overview 0
  • Commits 1
  • Changes 1

Closes #940 (closed)

Previous behaviour

Steps to reproduce:

  1. Send a push message that triggers an error
  2. The message is not marked as sent and hard crash

New behaviour

Steps to validate that it works:

  1. Send a push message that triggers an error
  2. The message is marked as sent and everything works
Edited Oct 17, 2019 by Sébastiaan Versteeg
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: thalia/concrexit!1381
Source branch: fix/firebase-error