Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • concrexit concrexit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • thaliathalia
  • concrexitconcrexit
  • Merge requests
  • !1381

Fix removal of Firebase Admin SDK error

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Sébastiaan Versteeg requested to merge fix/firebase-error into master Oct 17, 2019
  • Overview 0
  • Commits 1
  • Changes 1

Closes #940 (closed)

Previous behaviour

Steps to reproduce:

  1. Send a push message that triggers an error
  2. The message is not marked as sent and hard crash

New behaviour

Steps to validate that it works:

  1. Send a push message that triggers an error
  2. The message is marked as sent and everything works
Edited Oct 17, 2019 by Sébastiaan Versteeg
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/firebase-error