Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • concrexit concrexit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • thalia
  • concrexitconcrexit
  • Merge requests
  • !1477

Move review CI jobs to separate sh files

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Joren Vrancken requested to merge move-review-ci-files into master Jan 27, 2020
  • Overview 0
  • Commits 1
  • Changes 3

Description

This MR refactors the large complex CI jobs that create and remove the review hosts into Bash scripts.

This has multiple advantages:

  • No more complex Bash in Yaml (e.g. a heredoc in a multiline Yaml item).
  • Only executing tasks when needed instead of of using x | true.
  • Smaller, more readable CI config.
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: move-review-ci-files