Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • concrexit concrexit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • thalia
  • concrexitconcrexit
  • Merge requests
  • !577

Merged
Created Sep 20, 2017 by Tom van Bussel@tvbusselContributor

Do not create Photo objects for non-photo files when uploading albums

  • Overview 2
  • Commits 1
  • Changes 1

Closes #511 (closed)

Previous behaviour

Steps to reproduce:

  1. Go to photos admin and create a new Album
  2. Upload a zip which contains non-photo files.
  3. The admin panels warns that the non-photo file was ignored, yet a Photo object was created for it.

New behaviour

Steps to validate that it works:

  1. Go to photos admin and create a new Album
  2. Upload a zip which contains non-photo files.
  3. The admin panels warns that the non-photo file was ignored, and it was ignored.
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 511-dont-save-broken-photos