Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • concrexit concrexit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • thaliathalia
  • concrexitconcrexit
  • Merge requests
  • !865

WIP: Remember push notification category preferences when a device already exists

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Gijs Hendriksen requested to merge fix/keep-push-notification-categories into master Jul 12, 2018
  • Overview 1
  • Commits 1
  • Changes 1

Previous behaviour

Whenever a device tried to register after having already registered once before, all push notifications are enabled, no matter what the previous preferences were.

Steps to reproduce:

  1. Open the app on your phone.
  2. Notice a new Device is created which contains your phone's push notification preferences.
  3. Disable a few push notification categories.
  4. Close the app and reopen it (upon which your devices tries to register again).
  5. Notice all push notification categories are enabled.

New behaviour

When a device has already registered before, the next time it registers only the relevant fields will be updated, i.e. fields that are either in the body or implicitly transferred in the request (user, language).

Steps to validate that it works:

  1. Open the app on your phone.
  2. Notice a new Device is created which contains your phone's push notification preferences.
  3. Disable a few push notification categories.
  4. Close the app and reopen it (upon which your devices tries to register again).
  5. Notice the specific categories are still disabled.
Edited Jul 12, 2018 by Sébastiaan Versteeg
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/keep-push-notification-categories