Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • ThaliApp ThaliApp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 4
    • Merge requests 4
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • thaliathalia
  • ThaliAppThaliApp
  • Merge requests
  • !206

Fix/register button shown after late cancellation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gijs Hendriksen requested to merge fix/register-button-shown-after-late-cancellation into master Oct 03, 2018
  • Overview 1
  • Commits 1
  • Changes 3

Closes #72

Previous behaviour

The event detail shows the "Register" button and some wrong text when the user has cancelled after the cancellation deadline.

Steps to reproduce:

  1. Register for an event.
  2. Wait until the cancellation deadline has passed.
  3. Cancel your registration.
  4. Notice the app either displays the text "Cancellation is not possible anymore" (when the registration deadline has passed), or it displays the "Register" button (when the registration deadline has not yet passed).
  5. Notice the app crashes when the "Register" button is pressed.

New behaviour

The event detail displays the correct text and hides the "Register" button when needed.

Steps to validate that it works:

  1. Register for an event.
  2. Wait until the cancellation deadline has passed.
  3. Cancel your registration.
  4. Notice the app displays the text "Registration is not allowed anymore, as you cancelled your registration after the deadline" when the registration deadline has not yet passed, and the text "Cancellation is not possible anymore" is no longer displayed after the registration deadline.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/register-button-shown-after-late-cancellation